VideoPress: enable modernized dashboard by default#49023
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
keoshi
left a comment
There was a problem hiding this comment.
Confirmed the new UI loads and add_filter( 'rsm_jetpack_ui_modernization_videopress', '__return_false' ); shows the legacy one.
Two things worth noting, the first which I'd consider blocking:
- The VideoPress page is fully available pre-connection, making all uploads fail.
- I'm seeing the same header height change noted here.
Great catch! |
Fixed in #49063 |
Fixes #48506
Proposed changes
rsm_jetpack_ui_modernization_videopress) to defaulttrue, so the modernized wp-build dashboard is now served by default.add_filter( 'rsm_jetpack_ui_modernization_videopress', '__return_false' )) in case a regression needs a quick fallback.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
wp-admin/admin.php?page=jetpack-videopress).add_filter( 'rsm_jetpack_ui_modernization_videopress', '__return_false' );(e.g. in a mu-plugin or snippet) and reload the page; confirm the legacy dashboard is served, verifying the fallback path still works.