ci: Use GH concurrency queue instead of turnstile in pr-is-up-to-date.yml#49057
Open
anomiex wants to merge 1 commit into
Open
ci: Use GH concurrency queue instead of turnstile in pr-is-up-to-date.yml#49057anomiex wants to merge 1 commit into
anomiex wants to merge 1 commit into
Conversation
….yml GitHub has recently added the ability to have an actual queue (max 100 entries) for its concurrency feature. This should perform better than turnstile, so let's try it out. Also, there's a bit of cruft in the file: when I originally wrote it, I thought of it as one feature so I put it all in one file, and then had to get a bit hacky to avoid always having a skipped job in the PR check list. But we can also avoid that, more cleanly, by just having two independent workflows.
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
GitHub has recently added the ability to have an actual queue (max 100 entries) for its concurrency feature. This should perform better than turnstile, so let's try it out.
Also, there's a bit of cruft in the file: when I originally wrote it, I thought of it as one feature so I put it all in one file, and then had to get a bit hacky to avoid always having a skipped job in the PR check list. But we can also avoid that, more cleanly, by just having two independent workflows.
Related product discussion/links
p1779371671037339-slack-C05Q5HSS013
Does this pull request change what data or activity we track or use?
No
Testing instructions