ci: Use GH concurrency queue instead of turnstile in gardening.yml#49061
Open
anomiex wants to merge 1 commit into
Open
ci: Use GH concurrency queue instead of turnstile in gardening.yml#49061anomiex wants to merge 1 commit into
anomiex wants to merge 1 commit into
Conversation
GitHub has recently added the ability to have an actual queue (max 100 entries) for its concurrency feature. This should perform better than turnstile, so let's try it out. It turns out that having `concurrency` set at both the workflow level and the job level works the way we need it: each declaration operates completely independently of the other, so the job-level concurrency can group jobs together even if the workflow-level puts them in separate groups. We do still need to worry about collisions though. This does mean that multiple gardening jobs for a PR can't do the tool setup and build steps before waiting on the queue, but since that seems to take less than a minute I think we can accept that.
github-actions
Bot
added
the
Actions
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
GitHub has recently added the ability to have an actual queue (max 100 entries) for its concurrency feature. This should perform better than turnstile, so let's try it out.
It turns out that having
concurrencyset at both the workflow level and the job level works the way we need it: each declaration operates completely independently of the other, so the job-level concurrency can group jobs together even if the workflow-level puts them in separate groups. We do still need to worry about collisions though.This does mean that multiple gardening jobs for a PR can't do the tool setup and build steps before waiting on the queue, but since that seems to take less than a minute I think we can accept that.
Related product discussion/links
p1779371671037339-slack-C05Q5HSS013
Does this pull request change what data or activity we track or use?
No
Testing instructions