[codex] Fix Jetpack Search menu on Simple sites

[robfelty]

Fixes #

Proposed changes

• Keep Jetpack Search visible in the wp-admin Jetpack submenu on WordPress.com Simple sites by registering it directly under the Jetpack menu when appropriate.
• Re-add the Search dashboard during the late Simple-site Jetpack menu pass so the menu item is not dropped when the submenu is rebuilt.
• Guard the Jetpack compatibility offline-mode check for hosts whose Jetpack class does not provide that helper.
• Add Search dashboard unit coverage and changelog entries for the affected packages.

Related product discussion/links

• N/A

Does this pull request change what data or activity we track or use?

No.

Testing instructions

• Set a WordPress.com Simple site, or a Simple-site-like local environment, to a non-English language such as German.
• Open wp-admin and hover over Jetpack in the left admin menu.
• Confirm the Jetpack flyout includes Search between Monetize and Subscribers.
• Confirm the Search item opens the Jetpack Search dashboard.
• Run pnpm jetpack test php packages/search --verbose.
• Run pnpm jetpack test php packages/jetpack-mu-wpcom --verbose.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the codex/fix-jetpack-search-german-menu branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack codex/fix-jetpack-search-german-menu

bin/jetpack-downloader test jetpack-mu-wpcom-plugin codex/fix-jetpack-search-german-menu

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

Coverage changed in 5 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php	99/435 (22.76%)	-0.16%	3 ❤️‍🩹
projects/packages/search/src/class-package.php	4/12 (33.33%)	8.33%	-1 💚
projects/packages/search/src/class-module-control.php	105/111 (94.59%)	2.70%	-3 💚
projects/packages/search/compatibility/jetpack.php	5/8 (62.50%)	62.50%	-5 💚
projects/packages/search/src/dashboard/class-dashboard.php	21/67 (31.34%)	31.34%	-10 💚

Full summary · PHP report · JS report