e2e-commons: match editor panel name exactly to unblock post-editor e2e#49107
Merged
Conversation
The `openSettings` helper used `getByRole( 'menuitemcheckbox', { name: target } )`,
which does a substring match. After #49034 enabled the subscriptions module by
default, the editor More menu now exposes both "Jetpack" and "Jetpack Newsletter"
panels, so `openSettings( 'Jetpack' )` matches two elements and Playwright throws
a strict-mode violation. Adding `exact: true` restores the original single-match
behavior.
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the strict-mode violation currently breaking the Jetpack post editor e2e tests check on every PR (e.g. #49099, #49100, #49104).
Proposed changes
tools/e2e-commons/pages/editor-page.ts, theopenSettings()helper opens the editor's More menu and looks up the target panel toggle withgetByRole( 'menuitemcheckbox', { name: target } ). Playwright'snamedoes a substring match by default, soopenSettings( 'Jetpack' )resolves to both the "Jetpack" panel and the "Jetpack Newsletter" panel (registered atextensions/blocks/subscriptions/menu.js:42).sidebar-social.test.tsfails before it can even open the sidebar.exact: trueso the matcher requiresname === target.Why this only started failing now
The Newsletter panel has existed since #47857 (March), but it's only visible when the subscriptions module is active. #49034 (merged 2026-05-22 14:42 UTC) flipped subscriptions on by default, which is when the Jetpack post editor e2e job started failing on every subsequent PR.
Timeline:
Testing instructions
Does this pull request change what data or activity we track or use?
No.