Settings: open Jetpack Settings support links in Help Center on WordPress.com#49112
Draft
escapemanuele wants to merge 1 commit into
Draft
Settings: open Jetpack Settings support links in Help Center on WordPress.com#49112escapemanuele wants to merge 1 commit into
escapemanuele wants to merge 1 commit into
Conversation
…ress.com On WordPress.com (Simple/Atomic) sites, the "Learn more" links inside the Jetpack Settings cards used getRedirectUrl( 'jetpack-support-*' ) and opened in a new browser tab via jetpack.com/redirect. They should instead link to the matching wordpress.com/support documentation and open inside the Help Center, matching the existing wpcom-support-google-analytics pattern. Centralize the behavior in SupportInfo: - Accept new optional wpcomLink (and wpcomPostId) props. - When isWpcomPlatformSite() is true and wpcomLink is provided, render WpcomSupportLink (which dispatches to the help-center store when present, falling back to a new-tab anchor otherwise). The standalone Jetpack path keeps the original jetpack.com link, unchanged. - Hide the "Privacy information" link on WordPress.com — it is not relevant for Dotcom users (their privacy information lives in account-level docs). Add wpcomLink to every settings card called out in DOTCOM-17147 across: - Security: monitor, protect, sso - Performance: media (VideoPress), speed-up-site (site accelerator / CDN) - Writing: composing (copy-post, markdown, latex, shortcode-embeds), custom-content-types (testimonials, portfolios), theme-enhancements (infinite scroll), widgets (extra sidebar widgets + widget visibility), post-by-email - Sharing: publicize, share-buttons, likes - Discussion: comments - Traffic: related-posts, seo, site-stats, shortlinks, sitemaps, verification-services - Monetize: ads (wordads), index (payments / donations / pay-with-paypal) For EarnFeatureButton (earn/index.jsx) thread a new wpcomSupportLink prop through into the existing support object so each earn feature card can specify its own Dotcom doc. Part of DOTCOM-17147 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DOTCOM-17147
Proposed changes
components/support-info:wpcomLink/wpcomPostIdprops. WhenisWpcomPlatformSite()is true andwpcomLinkis provided, the "Learn more" link renders asWpcomSupportLinkso it opens inside the Help Center (or falls back to a new-tab anchor when the Help Center store is not present).jetpack.com/redirectlink, unchanged.wpcomLinkto every settings card called out in the issue: Security (monitor, protect, sso), Performance (media, speed-up-site), Writing (composing, custom-content-types, theme-enhancements, widgets, post-by-email), Sharing (publicize, share-buttons, likes), Discussion (comments), Traffic (related-posts, seo, site-stats, shortlinks, sitemaps, verification-services), Monetize (ads, payments / donations / pay-with-paypal).earn/index.jsx: thread a newwpcomSupportLinkprop throughEarnFeatureButtoninto the sharedsupportobject so each earn feature card can specify its own Dotcom doc.Related product discussion/links
Does this pull request change what data or activity we track or use?
No. The existing
recordJetpackClicktracking on the "Learn more" link is preserved (theonClickis passed through toWpcomSupportLink).Testing instructions
WordPress.com (Atomic, Business / Commerce plan)
(i)info icon and then Learn more.Standalone Jetpack site (Jurassic Ninja / self-hosted)
🤖 Generated with Claude Code