fix: apply default options consistently across all client functions #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
inlineContentandinlineDocumentfunctions were not applying default options correctly. This meant that when users calledjuice.inlineContent(html, css)orjuice.inlineContent(html, css, {}), for example, they wouldn't get expected default behaviors defined inlib/utils.js.Solution
Modified
inlineDocumentto callutils.getDefaultOptions(options), ensuring all client entry points properly merge provided options with defaults. This makes the behavior consistent withjuiceDocumentwhich already applied defaults here.Breaking changes
If you need the old behavior (no defaults applied), explicitly pass options to disable all truthy defaults:
as well as for
inlineDocument.