types: fix ApplyBasicCreateCasting and DeepPartial to better support VSCode intellisense#16047
Closed
types: fix ApplyBasicCreateCasting and DeepPartial to better support VSCode intellisense#16047
Conversation
Collaborator
AbdelrahmanHafez
left a comment
AbdelrahmanHafez
left a comment
There was a problem hiding this comment.
LGTM, we should be able to write tests that prevent regression for this in the future though.
hasezoey
reviewed
Feb 26, 2026
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
@AbdelrahmanHafez @hasezoey can you check whether this helps intellisense on your IDE?
From what i can tell, it was working fine before this PR (using vscode and typescript 5.9.3) and it also works after this pr.
(though note that my test case is "simpler" than the one shown in the screenshot, as i only did quick testing)
Collaborator
Author
|
Checking what @hasezoey , it looks like intellisense works fine without this PR too 😭 Likely some strange flake with my local dev environment. Next time I'll have to make sure to restart Zed and reboot TypeScript server a few times just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on #16012 I spotted that intellisense for
create()wasn't working at allWith this change, seems to work much better:
I borrowed heavily from the Vercel AI SDK's DeepPartial type for this implementation - their DeepPartial seems to work better with intellisense.
For some reason Boolean is still showing up as
anyin intellisense, I'm looking into that, but this change should still improve intellisense across the board.@AbdelrahmanHafez @hasezoey can you check whether this helps intellisense on your IDE?
Examples