evdev: improve capslock detection for no led device #923
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Caps Lock detection does not work correctly on my Sofle keyboard: the state instantly flips from true back to false.
After checking the logs, the cause is clear:
and inside the called function:
My keyboard has no physical Caps Lock LED, so
device.State(EV_LED)returns an empty map.Accessing it yields
false, which forces the state back to off every time.This PR adds a simple check: if
ledStatesis completely empty, we skip the update entirely instead of treating Caps Lock as off.The change has minimal impact on other devices:
ledStatesis non-empty (normal case), behaviour is unchanged.Actually, I wonder if it is even necessary to have the branch below since it seems EV_LED event will always be issued by the kernel?