Skip to content

Conversation

@sklppy88
Copy link
Collaborator

@sklppy88 sklppy88 commented Dec 3, 2025

No description provided.

@sklppy88 sklppy88 marked this pull request as draft December 3, 2025 19:49
@sklppy88 sklppy88 changed the title feat: add wallet example with webapp feat: add wallet example with webapp and explainer Dec 3, 2025
fix
@sklppy88 sklppy88 force-pushed the add-new-wallet-example-and-explainer branch from 4364242 to 86ecc2d Compare December 3, 2025 19:58
@sklppy88 sklppy88 requested a review from critesjosh December 3, 2025 19:59
Copy link
Contributor

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a github action that will test any PRs, similar to the existing ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to clarify the aztec version that this example is compatible with.


try {
const contract = await PrivateVotingContract.at(contractAddress, wallet);
await contract.methods.cast_vote(AztecAddress.random()).send({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cast_vote function takes a Field, not an AztecAddress.

I was seeing this error
image

but resolve with

      await contract.methods.cast_vote(1n).send({
        from: address
      }).wait();

abc
@sklppy88 sklppy88 force-pushed the add-new-wallet-example-and-explainer branch from 7d208e3 to ffc02de Compare December 8, 2025 14:13
@sklppy88 sklppy88 marked this pull request as ready for review December 8, 2025 14:13
@sklppy88 sklppy88 merged commit 0289202 into main Dec 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants