feat(avm)!: WIP remove `is_infinite` flags from ECADD opcode (outside AVM only) by MirandaWood · Pull Request #23031 · AztecProtocol/aztec-packages

MirandaWood · 2026-05-07T10:50:05Z

This branch includes the changes to remove the is_infinite flags from the ECADD opcode fn signature which reside outside vm2. This includes the transpiler, ts simulator, and anything required in ACIR.

Note that ACIR and noir's black box still use the flags and represent points by a triple of elements. Since this touches both private and public execution, I think it's out of scope of this task to update these.

Will partially close Foundation AVM Issue 19 (the previous PR with AVM changes will close the initial portion)

Stack:

MirandaWood · 2026-05-07T10:57:10Z

-                ADD d25, $2, d25; pointer to is_infinite
-                MOV i25, d24; is_infinite
-                ; Also store the original point in d25, d26, d27
+                ; Also store the original point in d25, d26


Note: to avoid a large diff/confusion, rather than shift all the addresses when removing inf I just left gaps (e.g. d24). Happy to remove these gaps though!

MirandaWood · 2026-05-08T14:43:10Z

 export const DEFAULT_MAX_DEBUG_LOG_MEMORY_READS = 125000;
 export enum DomainSeparator {
  NOTE_HASH = 116501019,
+  PARTIAL_NOTE_COMMITMENT = 568912195,


I think this is just leftover from some previous changes not updating constants - unrelated to this work!

…#22921) This branch solely contains the changes needed to remove the `is_infinite` flag from our `StandardAffinePoint` C++ wrapper. Now, we check whether `x` and `y` are zero to assign an `inf` underlying point. Will close [Foundation AVM Issue 17](https://linear.app/aztec-foundation/issue/AVM-17/remove-is-inf-flag-from-avms-standardaffinepoint) --- Stack: - #22745 - #22564 - `mw/avm-rem-inf-point-wrapper` <-- here - #22795 - #22945 - #23031

…y) (#22795) This branch includes the changes to remove the `is_infinite` flag from our point representation and conceptually treating a point as infinite iff its coordinates are `(0, 0)`. It only contains logic changes within the AVM for the above and does not touch the opcode - this is in a lower PR - so the **CI will probably fail**. Will close [Foundation AVM Issue 18](https://linear.app/aztec-foundation/issue/AVM-18/remove-is-inf-flag-from-resulting-ec-points-in-avm-circuits) --- Stack: - #22745 - #22564 - #22921 - `mw/avm-explore-remove-is-inf` <-- here - #22945 - #23031

…#22945) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature. The actual EC logic changes come above this PR in the stack, and any changes outside the AVM will be below. For ease of review, I've separated into commits: - **feat: remove inf flags from ecadd opcode - ec flow only** Isolated to the EC flow only (does not change registers so non avm tests will fail) - f**eat: rem infs from fuzzer (only gadget fuzzer tested)** Isolated fixes to get the fuzzer(s) compiling Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the following PR #23031 with ts/rs changes will fully close it). Note that the opcode mismatches that in ts so **CI will fail** until #23031 is merged into this branch! --- Stack: - #22745 - #22564 - #22921 - #22795 - `mw/avm-rem-inf-opcode-ecadd` <-- here - #23031

IlyasRidhuan · 2026-05-15T10:24:15Z

            input1_x: p1_x_offset,
            input1_y: p1_y_offset,
-            input1_infinite: p1_infinite_offset,
+            input1_infinite: _,


is this change waiting on upstream fixes in noir/brillig?

Pretty much - if I remove it there are cascading changes required in ACIR (IIRC), so I left it unused for now

…#22921) This branch solely contains the changes needed to remove the `is_infinite` flag from our `StandardAffinePoint` C++ wrapper. Now, we check whether `x` and `y` are zero to assign an `inf` underlying point. Will close [Foundation AVM Issue 17](https://linear.app/aztec-foundation/issue/AVM-17/remove-is-inf-flag-from-avms-standardaffinepoint) --- Stack: - #22745 - #22564 - `mw/avm-rem-inf-point-wrapper` <-- here - #22795 - #22945 - #23031

…y) (#22795) This branch includes the changes to remove the `is_infinite` flag from our point representation and conceptually treating a point as infinite iff its coordinates are `(0, 0)`. It only contains logic changes within the AVM for the above and does not touch the opcode - this is in a lower PR - so the **CI will probably fail**. Will close [Foundation AVM Issue 18](https://linear.app/aztec-foundation/issue/AVM-18/remove-is-inf-flag-from-resulting-ec-points-in-avm-circuits) --- Stack: - #22745 - #22564 - #22921 - `mw/avm-explore-remove-is-inf` <-- here - #22945 - #23031

…#22945) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature. The actual EC logic changes come above this PR in the stack, and any changes outside the AVM will be below. For ease of review, I've separated into commits: - **feat: remove inf flags from ecadd opcode - ec flow only** Isolated to the EC flow only (does not change registers so non avm tests will fail) - f**eat: rem infs from fuzzer (only gadget fuzzer tested)** Isolated fixes to get the fuzzer(s) compiling Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the following PR Note that the opcode mismatches that in ts so **CI will fail** until --- Stack: - #22745 - #22564 - #22921 - #22795 - `mw/avm-rem-inf-opcode-ecadd` <-- here - #23031

… AVM only) (#23031) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature which reside outside `vm2`. This includes the transpiler, ts simulator, and anything required in ACIR. Note that ACIR and noir's black box still use [the flags](https://github.com/AztecProtocol/aztec-packages/blob/b30fe8f401d7af45148071924b22b3f377750eaf/barretenberg/cpp/src/barretenberg/dsl/acir_format/ec_operations.hpp#L34) and represent points by a[ triple of elements.](https://github.com/noir-lang/noir/blob/bc4a37e2994ebc7d44ae98be81e18606b2231c61/acvm-repo/bn254_blackbox_solver/src/embedded_curve_ops.rs#L98) Since this touches both private and public execution, I think it's out of scope of this task to update these. Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the previous PR with AVM changes will close the initial portion) --- Stack: - #22745 - #22564 - #22921 - #22795 - #22945 - `mw/avm-rem-inf-opcode-ecadd-ext` <-- here

…#22921) This branch solely contains the changes needed to remove the `is_infinite` flag from our `StandardAffinePoint` C++ wrapper. Now, we check whether `x` and `y` are zero to assign an `inf` underlying point. Will close [Foundation AVM Issue 17](https://linear.app/aztec-foundation/issue/AVM-17/remove-is-inf-flag-from-avms-standardaffinepoint) --- Stack: - #22745 - #22564 - `mw/avm-rem-inf-point-wrapper` <-- here - #22795 - #22945 - #23031

…y) (#22795) This branch includes the changes to remove the `is_infinite` flag from our point representation and conceptually treating a point as infinite iff its coordinates are `(0, 0)`. It only contains logic changes within the AVM for the above and does not touch the opcode - this is in a lower PR - so the **CI will probably fail**. Will close [Foundation AVM Issue 18](https://linear.app/aztec-foundation/issue/AVM-18/remove-is-inf-flag-from-resulting-ec-points-in-avm-circuits) --- Stack: - #22745 - #22564 - #22921 - `mw/avm-explore-remove-is-inf` <-- here - #22945 - #23031

…#22945) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature. The actual EC logic changes come above this PR in the stack, and any changes outside the AVM will be below. For ease of review, I've separated into commits: - **feat: remove inf flags from ecadd opcode - ec flow only** Isolated to the EC flow only (does not change registers so non avm tests will fail) - f**eat: rem infs from fuzzer (only gadget fuzzer tested)** Isolated fixes to get the fuzzer(s) compiling Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the following PR Note that the opcode mismatches that in ts so **CI will fail** until --- Stack: - #22745 - #22564 - #22921 - #22795 - `mw/avm-rem-inf-opcode-ecadd` <-- here - #23031

… AVM only) (#23031) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature which reside outside `vm2`. This includes the transpiler, ts simulator, and anything required in ACIR. Note that ACIR and noir's black box still use [the flags](https://github.com/AztecProtocol/aztec-packages/blob/b30fe8f401d7af45148071924b22b3f377750eaf/barretenberg/cpp/src/barretenberg/dsl/acir_format/ec_operations.hpp#L34) and represent points by a[ triple of elements.](https://github.com/noir-lang/noir/blob/bc4a37e2994ebc7d44ae98be81e18606b2231c61/acvm-repo/bn254_blackbox_solver/src/embedded_curve_ops.rs#L98) Since this touches both private and public execution, I think it's out of scope of this task to update these. Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the previous PR with AVM changes will close the initial portion) --- Stack: - #22745 - #22564 - #22921 - #22795 - #22945 - `mw/avm-rem-inf-opcode-ecadd-ext` <-- here

…#22921) This branch solely contains the changes needed to remove the `is_infinite` flag from our `StandardAffinePoint` C++ wrapper. Now, we check whether `x` and `y` are zero to assign an `inf` underlying point. Will close [Foundation AVM Issue 17](https://linear.app/aztec-foundation/issue/AVM-17/remove-is-inf-flag-from-avms-standardaffinepoint) --- Stack: - #22745 - #22564 - `mw/avm-rem-inf-point-wrapper` <-- here - #22795 - #22945 - #23031

…y) (#22795) This branch includes the changes to remove the `is_infinite` flag from our point representation and conceptually treating a point as infinite iff its coordinates are `(0, 0)`. It only contains logic changes within the AVM for the above and does not touch the opcode - this is in a lower PR - so the **CI will probably fail**. Will close [Foundation AVM Issue 18](https://linear.app/aztec-foundation/issue/AVM-18/remove-is-inf-flag-from-resulting-ec-points-in-avm-circuits) --- Stack: - #22745 - #22564 - #22921 - `mw/avm-explore-remove-is-inf` <-- here - #22945 - #23031

…#22945) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature. The actual EC logic changes come above this PR in the stack, and any changes outside the AVM will be below. For ease of review, I've separated into commits: - **feat: remove inf flags from ecadd opcode - ec flow only** Isolated to the EC flow only (does not change registers so non avm tests will fail) - f**eat: rem infs from fuzzer (only gadget fuzzer tested)** Isolated fixes to get the fuzzer(s) compiling Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the following PR Note that the opcode mismatches that in ts so **CI will fail** until --- Stack: - #22745 - #22564 - #22921 - #22795 - `mw/avm-rem-inf-opcode-ecadd` <-- here - #23031

… AVM only) (#23031) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature which reside outside `vm2`. This includes the transpiler, ts simulator, and anything required in ACIR. Note that ACIR and noir's black box still use [the flags](https://github.com/AztecProtocol/aztec-packages/blob/b30fe8f401d7af45148071924b22b3f377750eaf/barretenberg/cpp/src/barretenberg/dsl/acir_format/ec_operations.hpp#L34) and represent points by a[ triple of elements.](https://github.com/noir-lang/noir/blob/bc4a37e2994ebc7d44ae98be81e18606b2231c61/acvm-repo/bn254_blackbox_solver/src/embedded_curve_ops.rs#L98) Since this touches both private and public execution, I think it's out of scope of this task to update these. Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the previous PR with AVM changes will close the initial portion) --- Stack: - #22745 - #22564 - #22921 - #22795 - #22945 - `mw/avm-rem-inf-opcode-ecadd-ext` <-- here

### Update Will also close [Foundation AVM Issue 13](https://linear.app/aztec-foundation/issue/AVM-13/enforce-canonical-point-at-infinity-representation) Note that this is currently being used as a base for removing the flag from AVM's point representation ([Foundation AVM Issue 14](https://linear.app/aztec-foundation/issue/AVM-14/remove-is-inf-flag-from-avm-ec-point-representation)): - ~#22745 (in merge train) - #23342 (ACIR changes from #23155 for removing `inf`) - #22564 <-- here - #22921 ✅ - #22795 ✅ - #22945 ✅ - #23031 ✅ **Everything in this branch has been reviewed**, see above PRs for individual work ⬆️ ### [OLD] Overview Will close [AVM-248](https://linear.app/aztec-labs/issue/AVM-248/enforce-canonical-point-at-infinity-representation) As a kind of stopgap before removing the `is_infinite` flag completely from the AVM ([AVM-266](https://linear.app/aztec-labs/issue/AVM-266/remove-is-inf-flag-from-ec-point-representation)), we now follow Noir behaviour more closely by deriving `is_inf` from coordinates inside the circuits ( `(x, y) == (0, 0) ? is_inf == true`). This replaces previous logic remapping points to (0, 0) from `is_inf`. This method relies on the on curve check (for `(0, 0) ==> is_inf `) and some new relations enforcing coordinates (for `is_inf ==> (0, 0)`) rather than (more expensive) error handling. However this does mean that the former will fail with an on curve error whereas the latter will simply fail a relation.

This was referenced May 7, 2026

feat(avm)!: WIP remove is_infinite flags from ECADD opcode (AVM only) #22945

Merged

feat(avm)!: Remove is_infinite flag from AVM (PIL and EC points only) #22795

Merged

chore(avm)!: Remove is_infinite flag from point wrapper constructor #22921

Merged

MirandaWood commented May 7, 2026

View reviewed changes

MirandaWood force-pushed the mw/avm-rem-inf-opcode-ecadd branch 3 times, most recently from 22dd20e to f0f77cb Compare May 8, 2026 10:55

MirandaWood force-pushed the mw/avm-rem-inf-opcode-ecadd-ext branch from 3a8ab34 to 0239103 Compare May 8, 2026 14:15

MirandaWood commented May 8, 2026

View reviewed changes

MirandaWood marked this pull request as ready for review May 8, 2026 14:44

MirandaWood requested review from IlyasRidhuan, LeilaWang, jeanmon and sirasistant as code owners May 8, 2026 14:44

MirandaWood removed request for LeilaWang, jeanmon and sirasistant May 8, 2026 14:44

MirandaWood mentioned this pull request May 12, 2026

feat(avm)!: Derive is_infinite flag from point coordinates #22564

Merged

MirandaWood force-pushed the mw/avm-rem-inf-opcode-ecadd branch from edf92df to 6b3e875 Compare May 12, 2026 16:32

Base automatically changed from mw/avm-rem-inf-opcode-ecadd to mw/avm-derive-is-inf May 13, 2026 08:19

MirandaWood added 6 commits May 13, 2026 08:23

fix: fully remove inf memory write

d929900

chore: docs, clear out old todos

ecde0c5

feat: first pass, change ECADD opcode sig in transpiler, y-p

492aa7f

chore: update gas cost for ECADD

faf94ad

chore: update vk after updating gas values

fe3d77e

chore: ts linting

5ab28e8

MirandaWood force-pushed the mw/avm-rem-inf-opcode-ecadd-ext branch from 1107aa2 to 5ab28e8 Compare May 13, 2026 08:24

MirandaWood added the ci-full Run all master checks. label May 13, 2026

IlyasRidhuan approved these changes May 15, 2026

View reviewed changes

MirandaWood merged commit 814108b into mw/avm-derive-is-inf May 15, 2026
25 checks passed

MirandaWood deleted the mw/avm-rem-inf-opcode-ecadd-ext branch May 15, 2026 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm)!: WIP remove `is_infinite` flags from ECADD opcode (outside AVM only)#23031

feat(avm)!: WIP remove `is_infinite` flags from ECADD opcode (outside AVM only)#23031
MirandaWood merged 6 commits into
mw/avm-derive-is-inffrom
mw/avm-rem-inf-opcode-ecadd-ext

MirandaWood commented May 7, 2026 •

edited

Loading

Uh oh!

MirandaWood May 7, 2026

Uh oh!

MirandaWood May 8, 2026

Uh oh!

IlyasRidhuan May 15, 2026

Uh oh!

MirandaWood May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MirandaWood commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MirandaWood May 7, 2026

Choose a reason for hiding this comment

Uh oh!

MirandaWood May 8, 2026

Choose a reason for hiding this comment

Uh oh!

IlyasRidhuan May 15, 2026

Choose a reason for hiding this comment

Uh oh!

MirandaWood May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MirandaWood commented May 7, 2026 •

edited

Loading