feat(avm)!: add immutables_hash member to get contract instance opcode#23152
Open
IlyasRidhuan wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
from
8e47d28 to
3ae27b1
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
2 times, most recently
from
f8f8953 to
9c8d4d8
Compare
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
2 times, most recently
from
08ca61f to
ca0212d
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
9c8d4d8 to
a91ac39
Compare
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
from
ca0212d to
af6ce8c
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
2 times, most recently
from
4311e6b to
3457e34
Compare
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
2 times, most recently
from
14be1b8 to
527035c
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
3457e34 to
524585d
Compare
IlyasRidhuan
requested review from
MirandaWood,
jeanmon,
nventuro and
sirasistant
as code owners
jeanmon
reviewed
May 15, 2026
| : is_class_id ? event.retrieved_class_id | ||
| : is_init_hash ? event.retrieved_init_hash | ||
| : FF(0); | ||
| FF selected_member = is_deployer ? event.retrieved_deployer_addr |
Contributor
There was a problem hiding this comment.
I think it would be nicer to check member_enum against ContractInstanceMember::MAX and then cast into the enum type ContractInstanceMember and using a switch.
jeanmon
approved these changes
May 15, 2026
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
I have one suggestion. Overall, it is good!
| /*expectedDeployer=*/ expectContractInstance.deployer, | ||
| /*expectedClassId=*/ expectContractInstance.currentContractClassId, | ||
| /*expectedInitializationHash=*/ expectContractInstance.initializationHash, | ||
| /*expectedImmutablesHash=*/ expectContractInstance.immutablesHash, |
Contributor
There was a problem hiding this comment.
Perfect that you thought about the bulk test! @IlyasRidhuan
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
from
527035c to
5879a73
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
524585d to
bf16019
Compare
dbanks12
approved these changes
May 15, 2026
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
from
5879a73 to
d92bdb8
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
bf16019 to
11df3f3
Compare
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
from
d92bdb8 to
bf1da80
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
11df3f3 to
de4bf52
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
de4bf52 to
582c604
Compare
IlyasRidhuan
force-pushed
the
ir/05-06-feat_avm_add_immutables_hash_member_to_get_contract_instance_opcode
branch
from
bf1da80 to
8322f9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of the immutables_hash changes as part of AZIP-9
This updates the
GETCONTRACTINSTANCEopcode so that theimmutables_hashcan be retrieved from the contract instance via the opcode.