feat: merge-train/fairies#23317
Merged
Merged
Conversation
They are currently set at 5.5 hours, which is excessive (last few runs were all under 20 minutes)
… delivery (#23278) Fixes https://linear.app/aztec-labs/issue/F-586/handshake-registry-non-interactive-handshake-function (updates work from #22854) Updated the handshake registry following the new spec in https://www.notion.so/aztecnetwork/Plan-Onchain-constrained-delivery-34fa1f6b0e358063b64ecc25b768c359 - We store the raw handshake secret in the Handshake note - The raw secret never leaves the registry. The registry app-siloes the secret against the `msg_sender` and returns it from the both the handshake and its utility method for fetching the siloed secret. - The registry provides a validation method to check the app siloed secret is for a valid handshake secret - Various additional tests. Mainly making sure we reject invalid handshakes and that we never expose the raw handshake secret - Linked directly to https://linear.app/aztec-labs/issue/F-653/route-handshake-log-through-do-private-message-delivery-to-preserve to implement as a follow-up I decided to just update the handshake registry directly rather than duplicating it with the old one. I felt if we ever wanted to go back to the old spec, we have the git history which we can reference for the old contract. Note packing bug was revealed with this work: https://linear.app/aztec-labs/issue/F-665/note-properties-generates-incorrect-selectors-for-custom-packed-fields I attempted to fitler notes after calling `get_notes` which through testing revealed itself as the incorrect way to filter notes. This should be made easier as it is a foot-gun for developers: https://linear.app/aztec-labs/issue/F-666/get-notes-and-view-notes-make-it-easy-to-filter-after-pagination --------- Co-authored-by: Nicolas Chamo <nicolas@chamo.com.ar>
…3115) Resolves [F-640](https://linear.app/aztec-labs/issue/F-640/aztec-nr-macros-extract-public-self-construction-in-internalutility) Stacks on #23062 This PR and its parent were ultimately attempts to reduce the static artifact size as a result of AztecProtocol/aztec-nr#35. This PR and its parent #23062 didn't end up showing any diff in the final byte code, but it significantly reduces macro code as can seen in the #23062 diff. It also assists the Noir optimizer/inliner as the construction of the `self` objects will be contained to a method rather than already inlined directly in each method. We leave inlining decisions to the compiler. This is better long-term to avoid blowups especially if we continue to add logic into the `self` constructors over time.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(aztec-up): fall back to no timeout when /usr/bin/timeout absent (macOS) (#23310)
chore: reduce compat e2e timeout (#23318)
feat(aztec-nr): V2 handshake registry for non interactive constrained delivery (#23278)
chore(aztec-nr): Public internal/utility methods self constructor (#23115)
END_COMMIT_OVERRIDE