feat(pxe)!: add source and block-range filtering to get_logs_by_tag#23326
Open
nchamo wants to merge 3 commits into
Open
feat(pxe)!: add source and block-range filtering to get_logs_by_tag#23326nchamo wants to merge 3 commits into
nchamo wants to merge 3 commits into
Conversation
nchamo
commented
May 15, 2026
| /// without actually using any of the new oracles then there is no reason to throw. | ||
| pub global ORACLE_VERSION_MAJOR: Field = 22; | ||
| pub global ORACLE_VERSION_MINOR: Field = 1; | ||
| pub global ORACLE_VERSION_MAJOR: Field = 23; |
Contributor
Author
There was a problem hiding this comment.
I would have expected this to be 12 (the version we decided protocol contracts were going to use), but apparently we are keeping it up to date with PXE's version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Constrained delivery introduces log tags that can be repeated across multiple logs and that only appear on private logs. The current
get_logs_by_tagoracle returns at most one log per tag and always queries both private and public RPCs, which doesn't work for this use case:from_block/to_blocklet callers scope queries to new blocks onlysourcefilter lets callers specify private, public, or bothOur fix
LogRetrievalRequestwithsource,from_block, andto_blockfields across the Noir-TS boundaryfetchLogsByTagto return all matching logs per tag (LogRetrievalResponse[][]) instead of only the first matchLogSourceenum (private / public / public-and-private) following the repo's struct-based enum pattern, with validation on TS deserialization[fromBlock, toBlock)semantics to matchAztecNodeconventionsFixes F-657
Fixes #15052