fix(aztec): use perl -i for portable in-place edit in add_crate.sh#23335
Open
nchamo wants to merge 1 commit into
Open
fix(aztec): use perl -i for portable in-place edit in add_crate.sh#23335nchamo wants to merge 1 commit into
nchamo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
aztec initfails on macOS withsed: -e: No such file or directory. Thesed -iinvocations inadd_crate.shrely on GNU sed's optional argument to-i; BSD sed (default on macOS) requires an explicit extension argument and otherwise treats the next token as the backup extension.Surfaced by the new macOS leg of the CLI acceptance test matrix being explored in branch
nchamo/f-566-explore-macos-ci-coverage-for-the-full-dev-onboarding-path.Fix
Replace the three
sed -icalls withperl -i -pe, which behaves identically across implementations. Regex syntax is unchanged except for the capture group switching from\(...\)to(...).