Skip to content

test(ci): flake-group new e2e_slashing tests to unblock merge-train/spartan#23356

Draft
AztecBot wants to merge 1 commit into
merge-train/spartanfrom
claudebox/fix-pr-23344-spartan-dequeue
Draft

test(ci): flake-group new e2e_slashing tests to unblock merge-train/spartan#23356
AztecBot wants to merge 1 commit into
merge-train/spartanfrom
claudebox/fix-pr-23344-spartan-dequeue

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Why

PR #23344 (the merge-train/spartan rollup) was dequeued from the merge queue twice in a row (2026-05-16 and 2026-05-18), each time after ~19–20 min — the timing signature of a test failing ~10 min into the test phase of a merge-queue-heavy grind, not a build error or timeout.

merge-queue-heavy mode runs 10 parallel ci-full-no-test-cache grinds + 1 arm64 fast (ci.sh:160), halting on the first failure. The same code passes the PR-time fast CI (single grind). The 10x grind is specifically there to surface flakes the single-grind misses.

The merge-train introduced two new test files (81c026ad42..48be067f5d) under yarn-project/end-to-end/src/e2e_slashing/attested_invalid_proposal.test.ts (#23184) and broadcasted_invalid_checkpoint_proposal_slash.test.ts (#23250). Both spin up a full P2PNetworkTest, use multiple retryUntil blocks with AZTEC_SLOT_DURATION * 3 timeouts, and have jest.setTimeout(1_000_000). Neither is covered by the existing flake patterns. The structurally-similar e2e_p2p/* and e2e_epochs/* directories are already blanket-grouped under e2e-p2p-epoch-flakes (threshold 5).

What

Add a single entry so src/e2e_slashing/*.test.ts joins the same flake group:

- regex: "src/e2e_slashing/.*\\.test\\.ts"
  flake_group_id: e2e-p2p-epoch-flakes
  owners:
    - *alex

Threshold is shared (5): up to 4 simultaneous flakes are tolerated; a real bug still fails CI.

Caveats

The merge-queue grind log is gated by GitHub admin / CI_PASSWORD, neither of which I have, so I could not pin the exact failing test from runs/26013363441. Full analysis and reasoning: https://gist.github.com/AztecBot/568994beba45c83968fed3f4359f8e88

./bootstrap.sh ci was not run locally — full CI requires Docker + EC2 spot orchestration that isn't reachable from this container.

ClaudeBox log: https://claudebox.work/s/65034965a86de4ab?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 18, 2026
@AztecBot AztecBot force-pushed the claudebox/fix-pr-23344-spartan-dequeue branch from 39006e8 to 86acc9b Compare May 18, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant