test(ci): flake-group sentinel_status_slash warp helper#23408
Draft
AztecBot wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks merge-train/spartan after PR #23344 was dequeued (run https://github.com/AztecProtocol/aztec-packages/actions/runs/26107178186, log http://ci.aztec-labs.com/4890aba571900836). The failing test,
e2e_p2p_sentinel_status_slash › slashes the proposer with INACTIVITY when checkpoint validation records invalid, errors out before reaching any slasher logic with:Why this flakes
In
warpToSlotBeforeTargetProposer, each iteration searches the slot range[currentSlot + 2, (currentEpoch + 2) * AZTEC_EPOCH_DURATION - 1]. WithAZTEC_EPOCH_DURATION = 2and a 2-slot buffer that eats most of the next epoch's slots, each iteration probes only 1–2 slots before callingadvanceToNextEpoch(). With a 6-validator committee and the proposer schedule shuffled per epoch, the 20-attempt budget can run out before the target validator rotates into a reachable slot.The slasher PR (#23394) that was the most recent commit on spartan does not touch this helper or the proposer schedule; this is a pre-existing setup-time probabilistic failure that the merge-queue's heavy grind (10x) surfaces more often than the PR-branch CI does.
Fix
Add the test to
.test_patterns.ymlwith noerror_regexso any failure of this test is treated as a flake — the test is brand new and shares the warp helper across all of its parallel cases, so scoping to a single error mode would leave us re-flaking on every neighbouring failure mode. The owner is Phil (added the test in #23286).A longer-term fix is to widen the search to span multiple epochs per iteration; that belongs in a follow-up rather than on the merge train.
ClaudeBox logs: