Skip to content

Conversation

@cfleschhut
Copy link

Purpose

  • Adds link to accompanying article/video tutorial on Azure docs site to README
    For people initially landing on this repo and wondering where to find the videos (like I just did) 🤓
  • Removes leftover code fragment in /src/App.js

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
npm t

What to Check

Verify that the following are valid

  • Added correct URL to article
  • <App /> component w/ <app-heroes /> removed renders correctly

Other Information

@msftclas
Copy link

msftclas commented Oct 30, 2018

CLA assistant check
All CLA requirements met.

@bbarrows89
Copy link

@microsoftopensource not sure who to bug, but this is a good PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants