e2e: app registration cleanup of orphaned app registrations that are expired

[bennerv]

ARO-25877

What

Creates a cleanup job for orphaned app registrations that didn't get cleaned up due to e2e panics or other things.

Why

Ensures that we clean up app registrations with expired credentials so they don't fill our object quota in our tenants.

Testing

openshift/release pj-rehearse plugin, otherwise ran locally.

Special notes for your reviewer

[Copilot]

Pull request overview

Adds a new cleanup subcommand to the aro-hcp-tests tooling to remove orphaned/expired e2e Microsoft Entra app registrations, and extends the curated Microsoft Graph Kiota spec + generated client to support listing owned applications.

Changes:

• Add cleanup app-registrations command and supporting options/run logic to delete expired e2e app registrations (with --dry-run support).
• Extend the Graph Kiota OpenAPI subset + generated client with /me/ownedObjects/graph.application.
• Standardize the e2e app registration name prefix via a shared graphutil.AppRegistrationPrefix constant.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tooling/kiota/README.md	Documents how to maintain the curated Graph OpenAPI subset.
tooling/kiota/openapi.yaml	Adds the /me/ownedObjects/graph.application endpoint to the curated spec.
test/util/framework/per_test_framework.go	Uses the shared app registration name prefix constant.
test/util/cleanup/appregistrations/options.go	Wires up Graph client acquisition for the new cleanup job.
test/util/cleanup/appregistrations/run.go	Implements list-and-delete flow for expired app registrations (dry-run supported).
test/cmd/aro-hcp-tests/cleanup/cmd.go	Adds the new cleanup app-registrations cobra subcommand.
internal/graph/util/applications.go	Adds ListOwnedExpiredApplications and the AppRegistrationPrefix constant.
internal/graph/graphsdk/me/*	Adds generated request builders for the /me/ownedObjects/graph.application calls.
internal/graph/graphsdk/graph_base_service_client.go	Exposes .Me() on the generated Graph service client.
internal/graph/graphsdk/kiota-lock.json	Updates Kiota lock hash due to spec changes.
internal/graph/graphsdk/models/odataerrors/inner_error.go	Fixes typo in generated comments (“occurred”).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bennerv]

/hold - need to confirm against a service principal login vs. a user login.

[bennerv]

/hold cancel

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[geoberle]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennerv, geoberle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• internal/OWNERS [bennerv,geoberle]
• test/OWNERS [bennerv,geoberle]
• tooling/kiota/OWNERS [bennerv,geoberle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment