Skip to content

test: add e2e test case for upgrading 4.21 nodepool#4835

Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom
jbriones/test/add-421-np-upgrade-e2e-tc
Apr 15, 2026
Merged

test: add e2e test case for upgrading 4.21 nodepool#4835
openshift-merge-bot[bot] merged 1 commit intomainfrom
jbriones/test/add-421-np-upgrade-e2e-tc

Conversation

@JameelB
Copy link
Copy Markdown
Collaborator

@JameelB JameelB commented Apr 10, 2026

What

Re-adding the 4.21 np upgrade test case, removed in #4793

Why

All related changes required to support 4.21 is now available (ARO-25490).

Testing

E2E test case added for testing 4.21 np upgrades.

Special notes for your reviewer

  • Test change only, no rollout required.
  • Should only be merged once CS version 28911b3 has been rolled out to all environments (see CS release dashboard)

@JameelB
Copy link
Copy Markdown
Collaborator Author

JameelB commented Apr 10, 2026

/hold

wait for cs changes to be rolled out to all envs.

Re-adding the 4.21 np upgrade test case since 4.21 is now supported (ARO-25490)
@JameelB JameelB force-pushed the jbriones/test/add-421-np-upgrade-e2e-tc branch from dd02814 to efc4336 Compare April 14, 2026 17:15
Comment thread test/e2e/nodepool_version_upgrade.go
@JameelB
Copy link
Copy Markdown
Collaborator Author

JameelB commented Apr 15, 2026

/unhold

required CS changes have now been deployed to all env and regions

@machi1990
Copy link
Copy Markdown
Collaborator

/lgtm

Copy link
Copy Markdown
Collaborator

@miquelsi miquelsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameelB, machi1990, miquelsi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0e6b4a0 into main Apr 15, 2026
17 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the jbriones/test/add-421-np-upgrade-e2e-tc branch April 15, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants