Conversation
… the control plane version
There was a problem hiding this comment.
Pull request overview
Updates the underlay AKS Kubernetes version to 1.33.7 for both svc and mgmt clusters, and introduces pipeline automation to perform the AKS upgrade as part of the infra pipelines.
Changes:
- Bump configured AKS Kubernetes version from 1.32.5 → 1.33.7 in
config/config.yamland rendered dev configs. - Add an
upgrade-aks-clustershell step to both svc and mgmt infra pipelines. - Add a new
dev-infrastructure/scripts/upgrade-aks-cluster.shscript that runsaz aks upgrade.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dev-infrastructure/svc-pipeline.yaml | Adds a pipeline step to upgrade the svc AKS cluster after deleting old user nodepools. |
| dev-infrastructure/mgmt-pipeline.yaml | Adds a pipeline step to upgrade the mgmt AKS cluster after deleting non-swift user nodepools. |
| dev-infrastructure/scripts/upgrade-aks-cluster.sh | New helper script to perform az aks upgrade using env-provided cluster/RG/version. |
| config/config.yaml | Updates default svc/mgmt AKS Kubernetes versions to 1.33.7. |
| config/rendered/dev/swft/uksouth.yaml | Updates rendered dev swft AKS versions to 1.33.7 (svc + mgmt). |
| config/rendered/dev/prow/westus3.yaml | Updates rendered dev prow AKS versions to 1.33.7 (svc + mgmt). |
| config/rendered/dev/pers/westus3.yaml | Updates rendered dev pers AKS versions to 1.33.7 (svc + mgmt). |
| config/rendered/dev/perf/westus3.yaml | Updates rendered dev perf AKS versions to 1.33.7 (svc + mgmt). |
| config/rendered/dev/dev/westus3.yaml | Updates rendered dev dev AKS versions to 1.33.7 (svc + mgmt). |
| config/rendered/dev/cspr/westus3.yaml | Updates rendered dev cspr AKS versions to 1.33.7 (svc + mgmt). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geoberle, tmstff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/test e2e-parallel |
|
/test e2e-parallel |
|
/test e2e-parallel |
https://redhat.atlassian.net/browse/ARO-25883
What
Upgrade AKS version to 1.33.8 for svc and mgmt.
Our current approach was not upgrading nodepool, but this PR adresses it with the
az aks upgradestep in both mgmt and svc pipeline. This is a preliminary solution until we have AKS Fleet in place.Why
We want to upgrade to AKS 1.35 to close possible gaps to the latest version - and we need to do it step by step.
1.33.x (x>8) will have a fix we need for swift
Testing
manual tests confirmed the functionality works.
prow E2E tests will not trigger real upgrades because the install version matches already the target version enforced by the upgrade script. in any case it is a noop
Special notes for your reviewer