feat: DiagnosticSetting - Update Bicep spec

[AlexanderSehr]

Overview/Summary

Changes the implementation so that if you configure only specs OR logs, the significant other is not automatically configured with allLogs / allMetrics.

With the new implementation, if you specify e.g., custom metrics, ONLY those are configured and nothing else.

Example deployment with updated code

No specification (default - expecting everthing to be configured)

diagnosticSettings: [
  {
    name: 'customSettingDef'
    eventHubName: diagnosticDependencies.outputs.eventHubNamespaceEventHubName
    eventHubAuthorizationRuleResourceId: diagnosticDependencies.outputs.eventHubAuthorizationRuleId
    storageAccountResourceId: diagnosticDependencies.outputs.storageAccountResourceId
    workspaceResourceId: diagnosticDependencies.outputs.logAnalyticsWorkspaceResourceId
  }
]

Custom specification (explicit metrics & logs)

diagnosticSettings: [
  {
    name: 'customSettingExpl'
    eventHubName: diagnosticDependencies.outputs.eventHubNamespaceEventHubName
    eventHubAuthorizationRuleResourceId: diagnosticDependencies.outputs.eventHubAuthorizationRuleId
    storageAccountResourceId: diagnosticDependencies.outputs.storageAccountResourceId
    workspaceResourceId: diagnosticDependencies.outputs.logAnalyticsWorkspaceResourceId
    metricCategories: [
      {
        category: 'AllMetrics'
      }
    ]
    logCategoriesAndGroups: [
      {
        category: 'Engine'
      }
      {
        category: 'Service'
      }
    ]
  }
]

Custom specification (only logs => should not configure metrics)

diagnosticSettings: [
  {
    name: 'customSettingOnlyLog'
    eventHubName: diagnosticDependencies.outputs.eventHubNamespaceEventHubName
    eventHubAuthorizationRuleResourceId: diagnosticDependencies.outputs.eventHubAuthorizationRuleId
    storageAccountResourceId: diagnosticDependencies.outputs.storageAccountResourceId
    workspaceResourceId: diagnosticDependencies.outputs.logAnalyticsWorkspaceResourceId
    logCategoriesAndGroups: [
      {
        category: 'Engine'
      }
      {
        category: 'Service'
      }
    ]
  }
]

Custom specification (only metrics => should not configure logs)

diagnosticSettings: [
  {
    name: 'customSettingOnlyMetric'
    eventHubName: diagnosticDependencies.outputs.eventHubNamespaceEventHubName
    eventHubAuthorizationRuleResourceId: diagnosticDependencies.outputs.eventHubAuthorizationRuleId
    storageAccountResourceId: diagnosticDependencies.outputs.storageAccountResourceId
    workspaceResourceId: diagnosticDependencies.outputs.logAnalyticsWorkspaceResourceId
    metricCategories: [
      {
        category: 'AllMetrics'
      }
    ]
  }
]

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

[ReneHezser]

Thank you, Alex