Skip to content

fix(vscode): Fix log subscriptions telemetry #8858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-eldridge wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(vscode): Fix log subscriptions telemetry #8858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c022cb8
fix unawaited log subscriptions
andrew-eldridge Feb 26, 2026
e12ee56
Merge branch 'main' of github.com:Azure/LogicAppsUX into aeldridge/su…
andrew-eldridge Mar 3, 2026
594109c
avoid blocking activate on subscriptions telemetry
andrew-eldridge Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/vs-code-designer/src/app/utils/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const logSubscriptions = async (context: IActionContext) => {
context.telemetry.properties.subscriptions = JSON.stringify(azureSubscriptions);
};

export const logExtensionSettings = async (context: IActionContext) => {
export const logExtensionSettings = (context: IActionContext) => {
const settingsToLog = [
'autoRuntimeDependenciesValidationAndInstallation',
'autoStartAzurite',
Expand Down
1 change: 1 addition & 0 deletions apps/vs-code-designer/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export const extensionCommand = {
debugLogicApp: 'azureLogicAppsStandard.debugLogicApp',
switchToDataMapperV2: 'azureLogicAppsStandard.dataMap.switchToDataMapperV2',
enableDevContainer: 'azureLogicAppsStandard.enableDevContainer',
logSubscriptions: 'azureLogicAppsStandard.logSubscriptions',
} as const;
export type extensionCommand = (typeof extensionCommand)[keyof typeof extensionCommand];

Expand Down
4 changes: 3 additions & 1 deletion apps/vs-code-designer/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ export async function activate(context: vscode.ExtensionContext) {

runPostWorkflowCreateStepsFromCache();
runPostExtractStepsFromCache();
callWithTelemetryAndErrorHandling(extensionCommand.logSubscriptions, async (actionContext: IActionContext) => {
await logSubscriptions(actionContext);
});

if (vscode.workspace.workspaceFolders && vscode.workspace.workspaceFolders.length > 0) {
await convertToWorkspace(activateContext);
Expand Down Expand Up @@ -159,7 +162,6 @@ export async function activate(context: vscode.ExtensionContext) {
perfStats.loadEndTime = Date.now();
activateContext.telemetry.measurements.mainFileLoad = (perfStats.loadEndTime - perfStats.loadStartTime) / 1000;

logSubscriptions(activateContext);
logExtensionSettings(activateContext);
});
}
Expand Down
Loading