Skip to content

meta(Automation): Fixed stale status issue#8948

Merged
rllyy97 merged 1 commit intomainfrom
riley/stale-status-fix
Mar 20, 2026
Merged

meta(Automation): Fixed stale status issue#8948
rllyy97 merged 1 commit intomainfrom
riley/stale-status-fix

Conversation

@rllyy97
Copy link
Contributor

@rllyy97 rllyy97 commented Mar 20, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Fixed issue with the stale daily status report pipeline action
Set the following values:

days-before-issue-stale: 1
days-before-issue-close: 0

Will now wait a day to mark as stale, then close immediately

Impact of Change

  • Users: N/A
  • Developers: Fixed issue with issue automation
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

** No testing needed for issue automation change **

Contributors

@rllyy97

Screenshots/Videos

N/A

@rllyy97 rllyy97 added the risk:low Low risk change with minimal impact label Mar 20, 2026
Copilot AI review requested due to automatic review settings March 20, 2026 16:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the actions/stale configuration for the daily status issue automation to address “stale” handling and labeling.

Changes:

  • Delays marking daily-status issues as stale from 0 to 1 day.
  • Changes close timing to occur immediately after becoming stale.
  • Renames the stale label from stale to stale-status.

@github-actions
Copy link

📊 Coverage Check

No source files changed in this PR.

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: meta(Automation): Fixed stale status issue
  • Issue: Title is acceptable and concise. It could be slightly more specific about the exact behavior change (optional).
  • Recommendation: Optional: make the title a touch more descriptive about the change, e.g. meta(Automation): Mark daily-status stale after 1 day and close immediately if you want to be explicit.

Commit Type

  • Properly selected (fix).
  • Note: Only one commit type selected, which is correct.

Risk Level

  • The PR body selects Low and the PR has the label risk:low. These match and are appropriate for this small workflow change.

What & Why

  • Current: Fixed issue with the stale daily status report pipeline action\nSet the following values:\n> days-before-issue-stale: 1\n> days-before-issue-close: 0\n\nWill now wait a day to mark as stale, then close immediately
  • Issue: Content is brief but clear. Consider adding why the previous values caused the problem and any example of the prior undesired behavior.
  • Recommendation: Add one sentence that explains the prior problem (e.g., "Previously issues were closed before they were marked stale due to reversed values, causing daily status items to be closed immediately").

⚠️ Impact of Change

  • Impact section is present but terse.
  • Recommendation: Clarify the affected scope slightly:
    • Users: N/A (automation for repo issue management)
    • Developers: Will affect issue automation for issues labeled daily-status (automation will now add stale-status after 1 day then close immediately)
    • System: No performance or architecture changes expected

⚠️ Test Plan

  • Assessment: The Test Plan boxes are all unchecked, and you added "** No testing needed for issue automation change **". For workflow changes this is often acceptable, but it's better to include a short validation plan.
  • Recommendation: Add simple validation steps to the Test Plan, for example:
    • Manually trigger the ISSUE_MANAGEMENT workflow in a test environment or on a test issue labeled daily-status and verify labeling/closing behavior.
    • Mention whether you ran/observed the updated action on a test issue (and when), or include the exact dry-run/verification steps if possible.

Contributors

  • Contributors section includes @rllyy97. Good. (Optional: include any reviewers/PMs if they participated.)

Screenshots/Videos

  • N/A — appropriate for non-visual change.

Summary Table

Section Status Recommendation
Title Optional: clarify behavior in title if desired
Commit Type None
Risk Level None
What & Why Add one sentence about the prior incorrect behavior
Impact of Change ⚠️ Expand to explicitly mention the daily-status label impact
Test Plan ⚠️ Add simple verification steps (manual trigger/test issue)
Contributors Optional: add reviewers if applicable
Screenshots/Videos N/A

Final Message
This PR is acceptable to merge as-is (passes). The code diff is small (3 lines changed in .github/workflows/ISSUE_MANAGEMENT.yml: swapping days-before-issue-stale from 0 -> 1, days-before-issue-close from 1 -> 0, and changing the stale label to stale-status) and represents a low-risk automation configuration fix — so risk:low is accurate.

Before merging, please consider the small improvements suggested above to make the PR description fully self-contained and easier for future reviewers: briefly explain the prior incorrect behavior and add a short Test Plan with validation steps (e.g., manual trigger against a test issue or description of observed run). Thank you!


Last updated: Fri, 20 Mar 2026 16:41:43 GMT

@rllyy97 rllyy97 merged commit db740f4 into main Mar 20, 2026
19 checks passed
@rllyy97 rllyy97 deleted the riley/stale-status-fix branch March 20, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants