firewall_manager: Add fallbacks when missing kernel modules#3511
Open
litian1992 wants to merge 1 commit intoAzure:developfrom
Open
firewall_manager: Add fallbacks when missing kernel modules#3511litian1992 wants to merge 1 commit intoAzure:developfrom
litian1992 wants to merge 1 commit intoAzure:developfrom
Conversation
litian1992
requested review from
ZhidongPeng,
maddieford,
nagworld9 and
narrieta
as code owners
litian1992
force-pushed
the
litian-missing-modules
branch
from
50b3525 to
1ddb664
Compare
litian1992
force-pushed
the
litian-missing-modules
branch
from
1ddb664 to
2ee7000
Compare
litian1992
force-pushed
the
litian-missing-modules
branch
from
2ee7000 to
261982a
Compare
In distro like RHEL, iptables relies on xt_conntrack and xt_owner kernel modules which live in kernel-modules-extra package. It is undesired in the world of UKI. Thus it's decided to be removed. Therefore in case of missing iptables, firewall-cmd needs checking. Fallback to network-setup service. Signed-off-by: Li Tian <litian@redhat.com>
litian1992
force-pushed
the
litian-missing-modules
branch
from
261982a to
0eef88a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are firewall rules invoked without checking the existence of the dependent kernel modules, e.g. xt_owner and xt_conntrack. These modules reside in kernel-modules-extra in distros like RHEL. The kernel-modules-extra package is not a dependency of iptables in terms of UKI. Thus the existence deserves checking. In case they are not present, fallback to nftables from iptables; to network-setup service from firewall-cmd respectively.
Issue #3510
PR information
developbranch.Quality of Code and Contribution Guidelines
Distro maintenance information, if applicable