Skip to content

Conversation

@DanielMicrosoft
Copy link
Contributor

@DanielMicrosoft DanielMicrosoft commented Oct 13, 2025

ADO Item: https://msazure.visualstudio.com/One/_workitems/edit/34561023

Updates items in the /workspace dir to be function-based React instead of class-based.

Todo before merging:

  • Change import structure from React.hookName to be named imports from "react".
  • Sub-components can go un sub-dir with parent to clean up dir structure.

Bugs to check:

  • Dismissing swagger picker on a new module without having loaded any resources-> goes to blank screen, was this incumbent?
  • Need to understand how to get "ClientConfig" viewable in DOM, before refactoring.
  • Verify that package.json changes wont have side effects.
  • Typos on app.

To get CI/CD to pass, had to change the build:typespec step due to an sec vuln upgrade:

The Vulnerability Timeline:
Published: "published_at": "2025-10-15T17:28:15Z"
Advisory: "V1.0 (October 14, 2025): Advisory published"
What this means:
The vulnerability was published on October 14-15, 2025 (just recently!)
Your previous PR with TypeSpec 1.4.0 passed because this vulnerability wasn't known yet
Now the same code fails because security scanners updated to flag Microsoft.Build 17.10.4
The affected version in your error:
Your error shows Microsoft.Build' 17.10.4 which falls in the vulnerable range:

Vulnerable: ">= 17.10.0, <= 17.10.29" ✅ (17.10.4 is in this range)
Patched: "17.10.46"

@DanielMicrosoft DanielMicrosoft changed the title [Feature]: update WorkspaceInstruction to use function-based react [Feature]: update FE to use function-based react Oct 14, 2025
@DanielMicrosoft DanielMicrosoft marked this pull request as ready for review October 22, 2025 04:52
@necusjz
Copy link
Member

necusjz commented Oct 23, 2025

thanks for the detailed report! i'll go through it.

@necusjz necusjz merged commit bd47939 into Azure:dev Oct 23, 2025
19 checks passed
@necusjz necusjz mentioned this pull request Oct 23, 2025
@DanielMicrosoft DanielMicrosoft deleted the 34561023-refactoring-move-to-function-components branch November 5, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants