Skip to content

[Feature]: Loading states for async operations in GUI #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
necusjz merged 32 commits into from
Nov 5, 2025
Merged

[Feature]: Loading states for async operations in GUI #533

necusjz merged 32 commits into from
Nov 5, 2025

Conversation

@DanielMicrosoft
Copy link
Contributor

@DanielMicrosoft DanielMicrosoft commented Oct 30, 2025 •
edited
Loading

ADO: https://msazure.visualstudio.com/One/_workitems/edit/34559798

Todo:

  • Verify should WorkspaceCreateDialog dismiss on off click
  • Update relevant usages.
  • Update /services api's to use the new pattern. (Only use those that effect/use loading state).
  • Test findingSimilarArgumentsOperation vs findingSimilarArguments.
  • Some API calls are not great candidates for the this new pattern (such as components with convering loading states), atleast update these components to use the same loading banner, for visual consistency.

@DanielMicrosoft
feature: (WIP) loading states for planes
a3413e5
@DanielMicrosoft
feature: (WIP) with loading component
5e47936
@DanielMicrosoft
feature: (WIP) adding todo comments
3a225f5
@DanielMicrosoft
Merge branch 'dev' of https://github.com/Azure/aaz-dev-tools into 345…
69a08fc 
…59798-add-loading-states-for-async-ops
@DanielMicrosoft
feature: refactor loading banner to new component
06ad799
@DanielMicrosoft
feature: refactor AsyncOperationBanner to use styled component
f68737e
@DanielMicrosoft
feature: add loading handling to WSEditorSwaggerPicker and WSEditorCl…
6b04820 
…ientConfig
@DanielMicrosoft
feature: fix contracting text colours
bf9cef3
@DanielMicrosoft
refactor: remove redundant comments
3a6ce78
@DanielMicrosoft
refactor: remove skipped tests, and adjust to match new api module pa…
e720808 
…ttern
@DanielMicrosoft
refactor: remove redundant comment
c8dc071
@DanielMicrosoft
refactor: make GenerateDialog use new async pattern
0776133
@DanielMicrosoft
refactor: change banner spinner to LinearProgress
b58ffbf
@DanielMicrosoft
refactor: remove loadingMessage string from cli api calls as they are…
da5a243 
… redundant
@DanielMicrosoft
refactor: GenerateDialog to use use async banner
978b23e
@DanielMicrosoft
refactor: commandApi.deleteOperation to new pattern
e8c4278
@DanielMicrosoft
refactor: fix tests for commandApi.deleteOperation
d827f1a
@DanielMicrosoft
refactor: update ExampleDialog loading handlers
d21c985
@DanielMicrosoft
refactor: update Outputdialog with new loading pattern
43922c7
@DanielMicrosoft
refactor: update ArgumentDialog to be using new pattern
1c91ae5
@DanielMicrosoft
refactor: update deleteWorkspace usages to new loading pattern
deba26f
@DanielMicrosoft
refactor: update renameWorkspace to use new loading pattern
dc395ba
@DanielMicrosoft
refactor: update deleteCommandgroup to use new loading pattern
6f9721e
@DanielMicrosoft
refactor: change loading message for loading resrouces
52bf0f0
@DanielMicrosoft
refactor: change AddSubcommandDialog to use new loading pattern
f53ca93
@DanielMicrosoft
refactor: COmmandGroupDialog to new loading pattenr
54563ff
@DanielMicrosoft
refactor: create uniform loading banner visual component
c29bdbc
@DanielMicrosoft
refactor: update remaining elements to use uniform version of LoadingBar
d9a3b2e
@DanielMicrosoft
refactor: remove comment
ac1c330
@DanielMicrosoft
refactor: remove jsx example in useAsyncOperation
257a2d5
@DanielMicrosoft DanielMicrosoft marked this pull request as ready for review November 5, 2025 02:06
@necusjz necusjz mentioned this pull request Nov 5, 2025
Merged
@necusjz necusjz merged commit 96aee05 into Azure:dev Nov 5, 2025
19 checks passed
@DanielMicrosoft DanielMicrosoft deleted the 34559798-add-loading-states-for-async-ops branch November 5, 2025 22:33
@DanielMicrosoft DanielMicrosoft mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@necusjz necusjz necusjz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielMicrosoft @necusjz