fix(purge): enforce ago limits and improve docs #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanreyl
requested review from
northtyphoon,
sajayantony and
wangxiaoxuan273
as code owners
FeynmanZhou
approved these changes
Dec 19, 2025
Member
FeynmanZhou
left a comment
FeynmanZhou
left a comment
There was a problem hiding this comment.
LGTM. Thanks @estebanreyl
gildardogmsft
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Previously, the --ago flag could overflow, resulting in a negative timeframe and unintended cleanup of all images in a repository. This PR introduces a cap of 150 years for the ago value. While ACR is far younger than that, this limit prevents accidental misuse from excessively large inputs.
Additionally, the documentation has been updated to clarify how to use filters for cleaning up only untagged images, which was the original scenario that led to discovering this bug.
Fixes #560