aks update node disruption profile flag#9893
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter node_disruption_policy |
|
Hi @erinborders, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9893 in repo Azure/azure-cli-extensions |
|
Hi @erinborders Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new preview flag to the aks-preview extension to let az aks update set the cluster-level node disruption policy (NodeDisruptionProfile), and documents/tests the behavior.
Changes:
- Add
--node-disruption-policy(preview) parameter wiring foraz aks update. - Introduce enum constants/argument registration for allowed policy values.
- Add a new scenario test and update the extension changelog.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/aks-preview/HISTORY.rst |
Documents the new az aks update --node-disruption-policy preview flag. |
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py |
Adds a scenario test intended to validate the new policy behavior. |
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py |
Adds context getter and update logic for node_disruption_policy and wires it into the preview update pipeline. |
src/aks-preview/azext_aks_preview/custom.py |
Extends aks_update signature to accept node_disruption_policy. |
src/aks-preview/azext_aks_preview/_params.py |
Registers the new CLI argument and allowed enum values. |
src/aks-preview/azext_aks_preview/_consts.py |
Adds constants for supported node disruption policy values. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.