Skip to content

aks update node disruption profile flag#9893

Open
erinborders wants to merge 7 commits into
Azure:mainfrom
erinborders:erinborders/nodedisruptionprofile
Open

aks update node disruption profile flag#9893
erinborders wants to merge 7 commits into
Azure:mainfrom
erinborders:erinborders/nodedisruptionprofile

Conversation

@erinborders
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@erinborders erinborders requested a review from FumingZhang as a code owner May 21, 2026 18:25
Copilot AI review requested due to automatic review settings May 21, 2026 18:25
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 21, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter node_disruption_policy

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @erinborders,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 21, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@erinborders
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 9893 in repo Azure/azure-cli-extensions

@github-actions
Copy link
Copy Markdown
Contributor

Hi @erinborders

Release Suggestions

Module: aks-preview

  • Update VERSION to 21.0.0b2 in src/aks-preview/setup.py

Notes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new preview flag to the aks-preview extension to let az aks update set the cluster-level node disruption policy (NodeDisruptionProfile), and documents/tests the behavior.

Changes:

  • Add --node-disruption-policy (preview) parameter wiring for az aks update.
  • Introduce enum constants/argument registration for allowed policy values.
  • Add a new scenario test and update the extension changelog.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/aks-preview/HISTORY.rst Documents the new az aks update --node-disruption-policy preview flag.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Adds a scenario test intended to validate the new policy behavior.
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Adds context getter and update logic for node_disruption_policy and wires it into the preview update pipeline.
src/aks-preview/azext_aks_preview/custom.py Extends aks_update signature to accept node_disruption_policy.
src/aks-preview/azext_aks_preview/_params.py Registers the new CLI argument and allowed enum values.
src/aks-preview/azext_aks_preview/_consts.py Adds constants for supported node disruption policy values.

Comment thread src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated
Comment thread src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Comment thread src/aks-preview/azext_aks_preview/_params.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants