{MySQL} az mysql flexible-server create: Remove --storage-redundancy parameter
#32525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy and
yonzhan
honghr
changed the title
az mysql flexible-server create: Remove --storage-redundancy parameter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the storage_redundancy parameter from MySQL flexible server commands, eliminating the ability to explicitly set local or zone redundancy during server creation, restore, geo-restore, and replica creation operations.
Key Changes
- Removed
storage_redundancyparameter from all flexible server command functions - Removed
storage_redundancy_arg_typedefinition and all related argument declarations - Updated test cases to remove
storage_redundancyvariable declarations and parameter usage
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/mysql/_params.py |
Removed storage_redundancy_arg_type definition and argument declarations from create, restore, geo-restore, and replica commands |
src/azure-cli/azure/cli/command_modules/mysql/custom.py |
Removed storage_redundancy parameter from function signatures and logic in create, restore, geo-restore, and replica functions |
src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_scenario.py |
Removed storage_redundancy variable declarations and parameter usage from test commands, but incomplete cleanup causes test failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_scenario.py
Show resolved
Hide resolved
Member
|
This is a breaking change so I'm afraid we can't merge this PR until next breaking change window. For now, pls add deprecation warning for this argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server create
az mysql flexible-server restore
az mysql flexible-server geo-restore
az mysql flexible-server replica create
Description
We need remove --storage-redundancy in CLI commands because we have deprecated this option in backend.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.