-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{RDBMS} Add autonomous-tuning command group to support all recommendation types for automated tuning & deprecate index-tuning #32546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…es for automated tuning & deprecate index-tuning
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| postgres flexible-server autonomous-tuning | sub group postgres flexible-server autonomous-tuning added |
||
| postgres flexible-server index-tuning | sub group postgres flexible-server index-tuning added property deprecate_info_redirect |
||
| postgres flexible-server index-tuning | sub group postgres flexible-server index-tuning added property deprecate_info_target |
||
| postgres flexible-server index-tuning list-recommendations | cmd postgres flexible-server index-tuning list-recommendations update parameter recommendation_type: updated property choices from ['CreateIndex', 'DropIndex'] to ['CreateIndex', 'DropIndex', 'ReIndex'] |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
…tonomous tuning capabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new autonomous-tuning command group for PostgreSQL flexible servers that extends the capabilities of the existing index-tuning command group to support multiple types of recommendations (index and table operations). The original index-tuning command group is being deprecated in favor of the new, more comprehensive autonomous-tuning group.
Key Changes:
- Added new
az postgres flexible-server autonomous-tuningcommand group with support for both index and table recommendations - Deprecated
az postgres flexible-server index-tuningcommand group with proper redirection messaging - Extended recommendation types to include ReIndex for indexes and AnalyzeTable/VacuumTable for tables
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test_rdbms_flexible_commands.py |
Renamed existing test class for index tuning and added comprehensive test class for new autonomous tuning commands |
flexible_server_custom_postgres.py |
Renamed recommendations_list to index_tuning_recommendations_list, added six new functions for autonomous tuning feature (update, show, settings operations, and recommendation listing for both index and table types), updated deprecated index tuning functions to use renamed settings map |
flexible_server_commands.py |
Registered new autonomous-tuning command group with commands for update, show, list/show/set settings, and list recommendations for both indexes and tables |
_util.py |
Renamed get_index_tuning_settings_map to get_autonomous_tuning_settings_map to reflect broader scope |
_params.py |
Added parameter definitions for all autonomous tuning commands including new recommendation types (ReIndex, AnalyzeTable, VacuumTable), updated index tuning parameters to use renamed settings map function |
_helptext_pg.py |
Added comprehensive help text and examples for all six autonomous tuning commands |
_flexible_server_location_capabilities_util.py |
Renamed variables from index_tuning to autonomous_tuning for consistency with new naming convention |
_breaking_change.py |
Registered deprecation of index-tuning command group with redirect to autonomous-tuning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…custom_postgres.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az postgres flexible-server index-tuningaz postgres flexible-server autonomous-tuningDescription
Introduce a new command group that extends the scope of index tuning to also cover other types of recommendations.
Testing Guide
A new test class was added to test all commands of the new
az postgres flexible-server autonomous-tuningcommand group.History Notes
[RDBMS]
az postgres flexible-server index-tuning: Deprecate and redirect toaz postgres flexible-server autonomous-tuningcommand group[RDBMS]
az postgres flexible-server autonomous-tuning list-index-recommendations/list-table-recommendations: Support listing index recommendations and table recommendationsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.