-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[RDBMS] az postgres flexible-server backup/db/firewall-rule/identity/long-term-retention/microsoft-entra-admin/migration/parameter/replica list: Allow --ids use for list commands
#32561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables --ids parameter support for nine different az postgres flexible-server list commands by modifying parameter configurations and adding appropriate linter exclusions. The changes consolidate parameter definitions and remove explicit id_part=None settings that were blocking --ids support.
- Introduced
server_name_resource_arg_typeandreplica_name_arg_typeto standardize parameter configurations - Removed explicit
id_part=Nonesettings from list commands to inheritid_part='name'from argument types - Improved naming in the replica promote function by renaming
server_nameparameter toreplica_namefor clarity - Consolidated and cleaned up parameter definitions across multiple command groups
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linter_exclusions.yml | Added no_ids_for_list_commands rule exclusions for 9 postgres flexible-server list commands to allow --ids parameter usage |
| flexible_server_custom_postgres.py | Renamed server_name parameter to replica_name in flexible_replica_promote function for improved semantic clarity |
| _params.py | Major parameter consolidation: introduced server_name_resource_arg_type and replica_name_arg_type, removed redundant parameter definitions, enabled --ids support by removing id_part=None settings from list commands, and cleaned up migration, backup, and other command parameter configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@evelyn-ys please trigger checks and review. We wish to move forward with this change |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list , az postgres flexible-server identity list , az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids use for list commandsaz postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids` use for list commands
az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids` use for list commandsaz postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids use for list commands
|
@evelyn-ys updated title, please rerun check. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@evelyn-ys can you please merge the PR? |
az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids use for list commandsaz postgres flexible-server backup/db/firewall-rule/identity/long-term-retention/microsoft-entra-admin/migration/parameter/replica list: Allow --ids use for list commands
Related command
postgres flexible-server backup list postgres flexible-server db list postgres flexible-server firewall-rule list postgres flexible-server identity list postgres flexible-server long-term-retention list postgres flexible-server microsoft-entra-admin list postgres flexible-server migration list postgres flexible-server parameter list postgres flexible-server replica listDescription
Cleaning up parameters file for better organization and use of
--idsargument for list commands.Testing Guide
History Notes
[RDBMS]
az postgres flexible-server backup/db/firewall-rule/identity/long-term-retention/microsoft-entra-admin/migration/parameter/replica list: Allow--idsuse for list commands