Skip to content

Conversation

@nasc17
Copy link
Member

@nasc17 nasc17 commented Dec 19, 2025

Related command
postgres flexible-server backup list postgres flexible-server db list postgres flexible-server firewall-rule list postgres flexible-server identity list postgres flexible-server long-term-retention list postgres flexible-server microsoft-entra-admin list postgres flexible-server migration list postgres flexible-server parameter list postgres flexible-server replica list

Description
Cleaning up parameters file for better organization and use of --ids argument for list commands.

Testing Guide

History Notes
[RDBMS] az postgres flexible-server backup/db/firewall-rule/identity/long-term-retention/microsoft-entra-admin/migration/parameter/replica list: Allow --ids use for list commands

Copilot AI review requested due to automatic review settings December 19, 2025 05:10
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 19, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 19, 2025

❌AzureCLI-BreakingChangeTest
❌rdbms
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd postgres flexible-server private-link-resource list cmd postgres flexible-server private-link-resource list update parameter server_name: added property required=True please remove property required=True for parameter server_name of cmd postgres flexible-server private-link-resource list
1008 - ParaPropAdd postgres flexible-server private-link-resource show cmd postgres flexible-server private-link-resource show update parameter server_name: added property required=True please remove property required=True for parameter server_name of cmd postgres flexible-server private-link-resource show
⚠️ 1008 - ParaPropAdd postgres flexible-server backup create cmd postgres flexible-server backup create update parameter backup_name: added property id_part=child_name_1
⚠️ 1008 - ParaPropAdd postgres flexible-server backup delete cmd postgres flexible-server backup delete update parameter backup_name: added property id_part=child_name_1
⚠️ 1008 - ParaPropAdd postgres flexible-server backup list cmd postgres flexible-server backup list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server db list cmd postgres flexible-server db list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server fabric-mirroring start cmd postgres flexible-server fabric-mirroring start update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server fabric-mirroring stop cmd postgres flexible-server fabric-mirroring stop update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server fabric-mirroring update-databases cmd postgres flexible-server fabric-mirroring update-databases update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server firewall-rule list cmd postgres flexible-server firewall-rule list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server identity assign cmd postgres flexible-server identity assign update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server identity list cmd postgres flexible-server identity list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server identity remove cmd postgres flexible-server identity remove update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server identity show cmd postgres flexible-server identity show update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server identity update cmd postgres flexible-server identity update update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server long-term-retention list cmd postgres flexible-server long-term-retention list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server long-term-retention pre-check cmd postgres flexible-server long-term-retention pre-check update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server long-term-retention show cmd postgres flexible-server long-term-retention show update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server long-term-retention start cmd postgres flexible-server long-term-retention start update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server microsoft-entra-admin create cmd postgres flexible-server microsoft-entra-admin create update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server microsoft-entra-admin delete cmd postgres flexible-server microsoft-entra-admin delete update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server microsoft-entra-admin list cmd postgres flexible-server microsoft-entra-admin list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server microsoft-entra-admin show cmd postgres flexible-server microsoft-entra-admin show update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server microsoft-entra-admin wait cmd postgres flexible-server microsoft-entra-admin wait update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server migration list cmd postgres flexible-server migration list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server parameter list cmd postgres flexible-server parameter list update parameter server_name: added property id_part=name
⚠️ 1008 - ParaPropAdd postgres flexible-server replica list cmd postgres flexible-server replica list update parameter server_name: added property id_part=name
⚠️ 1010 - ParaPropUpdate postgres flexible-server replica promote cmd postgres flexible-server replica promote update parameter server_name: updated property name from server_name to replica_name

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables --ids parameter support for nine different az postgres flexible-server list commands by modifying parameter configurations and adding appropriate linter exclusions. The changes consolidate parameter definitions and remove explicit id_part=None settings that were blocking --ids support.

  • Introduced server_name_resource_arg_type and replica_name_arg_type to standardize parameter configurations
  • Removed explicit id_part=None settings from list commands to inherit id_part='name' from argument types
  • Improved naming in the replica promote function by renaming server_name parameter to replica_name for clarity
  • Consolidated and cleaned up parameter definitions across multiple command groups

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
linter_exclusions.yml Added no_ids_for_list_commands rule exclusions for 9 postgres flexible-server list commands to allow --ids parameter usage
flexible_server_custom_postgres.py Renamed server_name parameter to replica_name in flexible_replica_promote function for improved semantic clarity
_params.py Major parameter consolidation: introduced server_name_resource_arg_type and replica_name_arg_type, removed redundant parameter definitions, enabled --ids support by removing id_part=None settings from list commands, and cleaned up migration, backup, and other command parameter configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nasc17
Copy link
Member Author

nasc17 commented Dec 19, 2025

@evelyn-ys please trigger checks and review. We wish to move forward with this change

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 20, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@nasc17 nasc17 changed the title [RDBMS] az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list , az postgres flexible-server identity list , az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids use for list commands [RDBMS] az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids` use for list commands Dec 22, 2025
@nasc17 nasc17 changed the title [RDBMS] az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids` use for list commands [RDBMS] az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids use for list commands Dec 22, 2025
@nasc17
Copy link
Member Author

nasc17 commented Dec 22, 2025

@evelyn-ys updated title, please rerun check.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 22, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mattboentoro
Copy link
Contributor

@evelyn-ys can you please merge the PR?

@evelyn-ys evelyn-ys changed the title [RDBMS] az postgres flexible-server backup list, az postgres flexible-server db list, az postgres flexible-server firewall-rule list, az postgres flexible-server identity list, az postgres flexible-server long-term-retention list, az postgres flexible-server microsoft-entra-admin list, az postgres flexible-server migration list, az postgres flexible-server parameter list, az postgres flexible-server replica list: Allow --ids use for list commands [RDBMS] az postgres flexible-server backup/db/firewall-rule/identity/long-term-retention/microsoft-entra-admin/migration/parameter/replica list: Allow --ids use for list commands Dec 24, 2025
@evelyn-ys evelyn-ys merged commit 2a6319e into Azure:dev Dec 24, 2025
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants