[App Service] Fix #27506, #29721: az webapp deploy: Add sync deployment support for --src-url#33052
Closed
[App Service] Fix #27506, #29721: az webapp deploy: Add sync deployment support for --src-url#33052
az webapp deploy: Add sync deployment support for --src-url#33052Conversation
️✔️AzureCLI-FullTest
|
|
Hi @seligj95, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Web Apps
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates App Service az webapp deploy behavior so deployments using --src-url behave synchronously by default (polling until completion), aligning with the --src-path experience and using a deployment ID from the ARM response to track status via the deploymentStatus API.
Changes:
- Add default synchronous polling behavior for
--src-urldeployments, with--async truepreserving immediate-return behavior. - Extract deployment ID from the ARM response (
idorproperties.deploymentId) and poll the ARM deploymentStatus endpoint to avoid “latest” race conditions. - Add unit tests to cover sync default, explicit
--async false, async, and “no deployment id” fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/appservice/custom.py |
Implements ARM-response deployment ID extraction and polling for --src-url; also introduces a new validation in config_source_control. |
src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py |
Adds unit tests validating sync/async behavior and fallback when no deployment ID is present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seligj95
changed the title
az webapp deploy: Add sync deployment support for --src-url
…rt for --src-url When using az webapp deploy --src-url, the command now polls for deployment completion by default (matching --src-path behavior). Uses the deployment ID from the ARM response to track status via the deploymentStatus API. - Default behavior for --src-url is now synchronous (polls until complete) - --async true preserves existing behavior (return immediately) - Uses deployment ID extraction for tracking (avoids race conditions) Fixes Azure#27506 Fixes Azure#29721 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
seligj95
force-pushed
the
fix/27506-29721-src-url-sync-deploy
branch
from
9f499ea to
a5b59d8
Compare
seligj95
changed the title
az webapp deploy: Add sync deployment support for --src-urlaz webapp deploy: Add sync deployment support for --src-url
Wrapped `--src-url` in backticks in PR title to pass format checker. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Consolidated into #33050 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
az webapp deploy --src-url, the command now polls for deployment completion by default, matching the behavior of--src-path. Uses the deployment ID from the ARM response to track status via the deploymentStatus API.Changes
--src-urlis now synchronous (polls until complete)--async truepreserves existing behavior (return immediately)Testing
Related Issues
Fixes #27506
Fixes #29721