Conversation
…ting, SKU listing, and slot instance support - Add 'az appservice plan list-skus' command (preview) to list available SKUs for a plan - Add 'az appservice plan list-slots' command (preview) to list deployment slots across all apps in a plan - Add examples to 'az webapp list-instances' showing --slot usage (already implemented) - Add unit tests for new plan commands Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
seligj95
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @seligj95, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appservice plan list-skus | cmd appservice plan list-skus added |
||
| appservice plan list-slots | cmd appservice plan list-slots added |
||
| webapp config connection-string list | cmd webapp config connection-string list update parameter name: added property id_part=name |
||
| webapp config public-cert | sub group webapp config public-cert added |
||
| webapp create | cmd webapp create update parameter container_registry_url: added property options_deprecate_info=[{'target': '--docker-registry-server-url', 'redirect': '--container-registry-url'}] |
||
| webapp create | cmd webapp create update parameter container_registry_url: updated property options from ['--container-registry-url'] to ['--container-registry-url', '--docker-registry-server-url'] |
||
| webapp deployment slot copy | cmd webapp deployment slot copy added |
||
| webapp log config | cmd webapp log config added parameter web_server_log_retention |
||
| webapp log config | cmd webapp log config added parameter web_server_log_sas_url |
||
| webapp log config | cmd webapp log config update parameter web_server_logging: updated property choices from ['filesystem', 'off'] to ['azureblobstorage', 'filesystem', 'off'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Web Apps
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the App Service CLI module by adding new (preview) commands to list selectable SKUs and deployment slots for an existing App Service plan, and by documenting slot usage for az webapp list-instances.
Changes:
- Added
az appservice plan list-skus(preview) to surface available plan SKUs viaget_server_farm_skus. - Added
az appservice plan list-slots(preview) to enumerate apps in a plan and list their deployment slots. - Expanded help examples for
az webapp list-instancesto include--slotusage, and added unit tests for the new plan commands.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/appservice/commands.py | Registers the new appservice plan subcommands (list-skus, list-slots) as preview. |
| src/azure-cli/azure/cli/command_modules/appservice/custom.py | Implements list_plan_skus() and list_plan_slots() backing the new commands. |
| src/azure-cli/azure/cli/command_modules/appservice/_params.py | Adds argument contexts for the new commands’ --name/-n handling. |
| src/azure-cli/azure/cli/command_modules/appservice/_help.py | Adds help entries for the new commands and slot examples for webapp list-instances. |
| src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py | Adds unit tests validating the new custom functions’ behavior under mocks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...zure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py
Outdated
Show resolved
Hide resolved
…ommand (preview) Add new command to copy content and configuration from one deployment slot to another using the REST API slotcopy endpoint. Unlike swap, this is a one-way operation that overwrites the target slot content. - Register command with is_preview=True in commands.py - Add --slot (source) and --target-slot (destination) parameters - Implementation uses send_raw_request since SDK lacks copy_slot method - Add help text with examples - Add unit tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… monitoring, logging, and infrastructure improvements - Azure#30030: Add Application Insights connection string and instrumentation key examples to `webapp config appsettings set` help with guidance on enabling App Insights monitoring via app settings. - Azure#10043: Add Azure Blob Storage support for web server logging via `--web-server-logging azureblobstorage` with new `--web-server-log-sas-url` and `--web-server-log-retention` parameters in `webapp log config`. - Azure#29147: Add warning message and documentation to `webapp traffic-routing set` about potential app restart when updating traffic routing configuration (known platform behavior). - Azure#28987: Add VNet/private endpoint guidance to `webapp config backup create` and `webapp config backup restore` help text, documenting requirements for backup/restore with storage accounts behind VNets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… connection-string IDs, docker create params, log help, public certs - Azure#15647: Enable --ids support for 'az webapp config connection-string list' by removing id_part=None override and cleaning up incorrect explicit --ids arg with required=True on the connection-string argument context. - Azure#17674: Add --docker-registry-server-url deprecated alias to 'webapp create' container_registry_url param. Also set DOCKER_REGISTRY_SERVER_* app settings during Linux container creation (previously only set for Windows containers). - Azure#29760: Improve --docker-container-logging help text in _params.py and _help.py. Clarify 'filesystem' vs 'off' values and add long-summary to 'webapp log config'. - Azure#12391: Add 'az webapp config public-cert' command group with upload, list, show, and delete subcommands for managing public certificates (.cer/.crt) on web apps via the PublicCertificate REST API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
seligj95
changed the title
This was referenced Mar 26, 2026
…, clean tests - list_plan_slots: derive slot name from slot.id instead of mutating slot.name - _params.py: use minimal overrides for list-skus/list-slots name arg (id_part=None) instead of redundantly redefining what parent appservice plan context provides - tests: remove unused setUp/self.client, drop unused WebSiteManagementClient import - tests: add slot.id to mock for realistic resource ID parsing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
seligj95
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated PR
This PR consolidates the following PRs into a single changeset:
az webapp deployment slot copycommand (preview) #33069: Fix WebApp: Add command for copying slots on Azure Web Apps (in preview) #16111 —az webapp deployment slot copycommand (preview)--docker-container-loggingneeds more explanation #29760, webapp: Add ability to upload public certificates without private key #12391 — connection-string IDs, docker create params, log help, public certsIssues Fixed
az appservice plan showshould list SKUsaz webapp showshould support slot instancesaz webapp deployment slot copycommandaz webapp config connection-string listshould include resource IDsaz webapp createdocker parameters--docker-container-loggingneeds more explanation #29760:az webapp loghelp text improvementsaz webapp config sslpublic certificate supportTesting
All changes include unit tests via
test_webapp_commands_thru_mock.py. Style (azdev style appservice) passes cleanly.