{Network} Upgrade API Version of Application Gateway#33080
Open
{Network} Upgrade API Version of Application Gateway#33080
Conversation
huiii99
requested review from
DanielMicrosoft,
ReaNAiveD,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @huiii99, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the Network Application Gateway AAZ command implementations to a newer ARM API version, with corresponding schema refreshes and a new scenario test to validate HTTP settings flags behavior.
Changes:
- Bump Application Gateway-related AAZ commands from
2023-11-01to2024-10-01. - Refresh read schemas (identity modeling, new/updated properties) across multiple subcommands.
- Add a scenario test covering
http-settings createvalidation flags persistence.
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py | Adds scenario test for http-settings validate flags. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/rule/_wait.py | API version bump + schema refresh for rule wait path. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/rule/_show.py | API version bump + schema refresh for rule show. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/rule/_list.py | API version bump + adjusts selector output behavior + schema refresh. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/rule/_delete.py | API version bump + schema refresh for rule delete. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/redirect_config/_wait.py | API version bump + schema refresh for redirect-config wait. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/redirect_config/_show.py | API version bump + schema refresh for redirect-config show. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/redirect_config/_list.py | API version bump + adjusts selector output behavior + schema refresh. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/redirect_config/_delete.py | API version bump + schema refresh for redirect-config delete. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/http_listener/_wait.py | API version bump + schema refresh for http-listener wait. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/http_listener/_show.py | API version bump + schema refresh for http-listener show. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/http_listener/_list.py | API version bump + adjusts selector output behavior + schema refresh. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/http_listener/_delete.py | API version bump + schema refresh for http-listener delete. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/address_pool/_wait.py | API version bump + schema refresh for address-pool wait. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/address_pool/_show.py | API version bump + schema refresh for address-pool show. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/address_pool/_list.py | API version bump + adjusts selector output behavior + schema refresh. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/address_pool/_delete.py | API version bump + schema refresh for address-pool delete. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_wait.py | API version bump + schema refresh for gateway wait. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_update.py | API version bump + schema refresh; removes enable_fips handling. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_show.py | API version bump + schema refresh for gateway show. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_health_on_demand.py | Schema refresh for health-on-demand responses. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_health.py | Schema refresh for backend health responses. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_delete.py | API version bump for gateway delete. |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_update.py:90
network application-gateway updateno longer defines theenable_fips/--enable-fipsargument in the AAZ argument schema, but this flag is still exposed vianetwork/_params.pyand is used by existing scenario tests (e.g.,test_network_app_gateway_with_defaults). This is a breaking change/regression unless the flag was intentionally removed from the command surface; consider re-addingenable_fipsto the Update command schema (and wiring it toproperties.enableFips) or updating the custom wrapper/tests and public help accordingly.
help="Custom error configurations of the application gateway resource.",
nullable=True,
)
_args_schema.http2 = AAZBoolArg(
options=["--http2"],
help="Use HTTP2 for the application gateway",
nullable=True,
)
_args_schema.capacity = AAZIntArg(
options=["--capacity"],
help="Number of instances to use with the application gateway.",
nullable=True,
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...zure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/_update.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Show resolved
Hide resolved
huiii99
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gatewayaz network application-gateway ruleaz network application-gateway redirect-configaz network application-gateway address-poolaz network application-gateway http-listenerDescription
Upgrade api version of network application gateway
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.