{Misc.} Remove aladdin logic due to service will be sunset#33104
Open
{Misc.} Remove aladdin logic due to service will be sunset#33104
Conversation
necusjz
requested review from
DanielMicrosoft,
ReaNAiveD and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Azure CLI core’s dependency on the Aladdin service for error-time command recommendations, and updates messaging around az find in preparation for service retirement/sunset.
Changes:
- Remove Aladdin-based recommendation logic from
CommandRecommenderand route parser errors to example-based recommendations. - Update
AzCLIErrorto store/print “example recommendations” instead of “Aladdin recommendations”. - Remove
az findpromotional messaging from help output and adjustaz finderror messaging.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/find/custom.py |
Updates non-200 response handling message for az find. |
src/azure-cli-core/azure/cli/core/tests/test_command_recommender.py |
Removes tests tied to deleted Aladdin error-type logic. |
src/azure-cli-core/azure/cli/core/parser.py |
Switches recommendation setter from Aladdin to example-based recommendations. |
src/azure-cli-core/azure/cli/core/command_recommender.py |
Removes Aladdin request/error-type logic; relies on help examples only. |
src/azure-cli-core/azure/cli/core/cloud.py |
Removes the Aladdin-specific “forbidding clouds” constant. |
src/azure-cli-core/azure/cli/core/azclierror.py |
Renames and adjusts recommendation storage/printing to “example recommendations”. |
src/azure-cli-core/azure/cli/core/_help.py |
Removes printing of the az find hint from help output (cached and non-cached). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
necusjz
requested review from
isra-fel,
notyashhh,
teresaritorto and
xuming-ms
as code owners
DanielMicrosoft
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
mainly 2 parts:
az findbefore:
after:
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.