[App Config] Update CLI to use Audience#33393
Conversation
mrm9084
requested review from
DanielMicrosoft,
Pan-Qi,
ReaNAiveD,
VeryEarly,
bebound,
jiasli,
jsntcy,
necusjz and
yonzhan
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Hi @mrm9084, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
microsoft-github-policy-service
Bot
requested review from
avanigupta,
yanzhudd and
zhoxing-ms
microsoft-github-policy-service
Bot
added
App Configuration
Auto-Assign
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR prepares az appconfig for azure-appconfiguration 1.8.0 by changing AAD login auth to provide an audience when the active cloud does not define one.
Changes:
- Bumps
azure-appconfigurationdependency in setup metadata to~=1.8.0. - Falls back to using the App Configuration endpoint as the token audience.
- Updates an AAD auth live test assertion for the new audience behavior.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/setup.py |
Updates the App Configuration SDK dependency version. |
src/azure-cli/azure/cli/command_modules/appconfig/_utils.py |
Adds endpoint fallback for App Configuration token audience selection. |
src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_aad_auth.py |
Updates the expected credential audience in the live AAD auth scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DEPENDENCIES = [ | ||
| "antlr4-python3-runtime~=4.13.1", | ||
| 'azure-appconfiguration~=1.7.2', | ||
| 'azure-appconfiguration~=1.8.0', |
| else: | ||
| token_audience = endpoint |
|
|
||
| # Assert that the ClientCredential was instantiated with no custom scope | ||
| cred_mock.assert_called_with(mock.ANY, None) | ||
| # Assert that the ClientCredential was instantiated with the endpoint as the token audience |
|
The PR title should probably also mention the sdk version update |
Related command
az appconfig
Description
When updating to the
1.8.0version of the python sdk it will result in us breaking in all non hardcoded regions, such as Bleu.This PR adds a check that will attempt to get the audience from the endpoint if an audience isn't provided.
Testing Guide
Get a config store in Bleu, you'll see that you can connect without providing the audience manually like you can in 1.7.2.
History Notes
Make is so the 1.8.0 release of the python sdk will not break all of our existing customers in non-public/ff/mc clouds.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.