Skip to content

Conversation

@FabianMeiswinkel
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings December 8, 2025 22:37
@github-actions github-actions bot added common common module used by all azure SDKs (e.g. client, Mgmt) Cosmos labels Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Scala 2.13 support for the Azure Cosmos DB Spark 3.5 connector by creating a new module azure-cosmos-spark_3-5_2-13. The changes include refactoring parent POMs to support parameterized Scala versions, adding CI/CD pipeline configurations for the new module, and creating documentation and configuration files for the Scala 2.13 variant.

Key Changes:

  • New module azure-cosmos-spark_3-5_2-13 with Scala 2.13 support for Spark 3.5
  • Parameterization of Scala version properties in parent POMs to support multiple Scala versions
  • CI/CD pipeline updates to include the new module in build and test workflows

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sdk/cosmos/spark.yml Added new Databricks test configuration for Scala 2.13 variant
sdk/cosmos/spark.databricks.yml Parameterized JAR_NAME to support multiple Spark/Scala versions
sdk/cosmos/pom.xml Added azure-cosmos-spark_3-5_2-13 module to build
sdk/cosmos/ci.yml Added new module to CI triggers, parameters, and artifacts list
sdk/cosmos/azure-cosmos-spark_3/pom.xml Refactored to use parameterized Scala version properties
sdk/cosmos/azure-cosmos-spark_3-5_2-13/* New module with POM, README, CONTRIBUTING, CHANGELOG, and config files
sdk/cosmos/azure-cosmos-spark_3-5_2-12/pom.xml Added Scala version properties for consistency
sdk/cosmos/azure-cosmos-spark_3-5/pom.xml Parameterized Scala dependencies
eng/versioning/version_client.txt Added version entry for new module
eng/versioning/external_dependencies.txt Added Scala 2.13 dependency entries
eng/.docsettings.yml Added documentation settings for new module
.vscode/cspell.json Added spelling exceptions for new module

skipPublishDocGithubIo: true
skipPublishDocMs: true
releaseInBatch: ${{ parameters.release_azurecosmosspark35 }}
releaseInBatch: ${{ release_azurecosmosspark35-scala213 }}
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parameters. prefix in the parameter reference. It should be ${{ parameters.release_azurecosmosspark35-scala213 }} instead of ${{ release_azurecosmosspark35-scala213 }} to be consistent with other parameter references in the file.

Suggested change
releaseInBatch: ${{ release_azurecosmosspark35-scala213 }}
releaseInBatch: ${{ parameters.release_azurecosmosspark35-scala213 }}

Copilot uses AI. Check for mistakes.
Comment on lines +41 to +48
| 4.34.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.33.1 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.33.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.32.1 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.32.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.31.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.30.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.29.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section heading should be azure-cosmos-spark_3-5_2-13 instead of azure-cosmos-spark_3-5_2-12 to match this module's artifact ID. Additionally, the "Supported Scala Versions" column in the table should show 2.13 instead of 2.12 to accurately reflect this module's Scala version.

Suggested change
| 4.34.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.33.1 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.33.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.32.1 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.32.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.31.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.30.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
| 4.29.0 | 3.5.0 | [8, 11] | 2.12 | 14.\*, 15.\* | |
#### azure-cosmos-spark_3-5_2-13
| Connector | Supported Spark Versions | Supported JVM Versions | Supported Scala Versions | Supported Databricks Runtimes | Supported Fabric Runtimes |
|-----------|--------------------------|------------------------|--------------------------|-------------------------------|---------------------------|
| 4.34.0 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.33.1 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.33.0 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.32.1 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.32.0 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.31.0 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.30.0 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |
| 4.29.0 | 3.5.0 | [8, 11] | 2.13 | 14.\*, 15.\* | |

Copilot uses AI. Check for mistakes.
<maven.test.skip>${cosmos.spark.skip}</maven.test.skip>

<cosmos-spark-version>3.1</cosmos-spark-version>
<cosmos-spark-version>3.3</cosmos-spark-version>
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cosmos-spark-version property was updated from 3.1 to 3.3, but this change seems unrelated to adding Scala 2.13 support. This appears to be either a mistake or an undocumented breaking change. Please verify this version bump is intentional and if so, document it appropriately or revert it if it's unintentional.

Suggested change
<cosmos-spark-version>3.3</cosmos-spark-version>
<cosmos-spark-version>3.1</cosmos-spark-version>

Copilot uses AI. Check for mistakes.
# Contributing
This instruction is guideline for building and code contribution.

## Prequisites
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spelling "Prequisites" is incorrect. It should be "Prerequisites".

Suggested change
## Prequisites
## Prerequisites

Copilot uses AI. Check for mistakes.

```bash
git clone https://github.com/Azure/azure-sdk-for-java.git
cd sdk/cosmos/azure-cosmos-spark_3-5_2-12
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory path in the build instructions is incorrect. It should be azure-cosmos-spark_3-5_2-13 instead of azure-cosmos-spark_3-5_2-12 to match this module's name.

Suggested change
cd sdk/cosmos/azure-cosmos-spark_3-5_2-12
cd sdk/cosmos/azure-cosmos-spark_3-5_2-13

Copilot uses AI. Check for mistakes.

- Skip tests execution
```bash
mvn clean install -Dgpg.skip-DskipTests
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space between -Dgpg.skip and -DskipTests. It should be mvn clean install -Dgpg.skip -DskipTests.

Suggested change
mvn clean install -Dgpg.skip-DskipTests
mvn clean install -Dgpg.skip -DskipTests

Copilot uses AI. Check for mistakes.
Comment on lines +143 to +147
`com.azure.cosmos.spark:azure-cosmos-spark_3-5_2-12:4.41.0`

You can also integrate against Cosmos DB Spark Connector in your SBT project:
```scala
libraryDependencies += "com.azure.cosmos.spark" % "azure-cosmos-spark_3-5_2-12" % "4.41.0"
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact ID references azure-cosmos-spark_3-5_2-12 but should be azure-cosmos-spark_3-5_2-13 to match this module. The version should also be updated to 4.42.0-beta.1 to match the current version in version_client.txt and the pom.xml.

Suggested change
`com.azure.cosmos.spark:azure-cosmos-spark_3-5_2-12:4.41.0`
You can also integrate against Cosmos DB Spark Connector in your SBT project:
```scala
libraryDependencies += "com.azure.cosmos.spark" % "azure-cosmos-spark_3-5_2-12" % "4.41.0"
`com.azure.cosmos.spark:azure-cosmos-spark_3-5_2-13:4.42.0-beta.1`
You can also integrate against Cosmos DB Spark Connector in your SBT project:
```scala
libraryDependencies += "com.azure.cosmos.spark" % "azure-cosmos-spark_3-5_2-13" % "4.42.0-beta.1"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common common module used by all azure SDKs (e.g. client, Mgmt) Cosmos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant