Skip to content

Enable native access for Netty common to prevent Windows testing error #47583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
alzimmermsft wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Enable native access for Netty common to prevent Windows testing error #47583

alzimmermsft wants to merge 4 commits into from

Conversation

@alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Dec 19, 2025 •
edited
Loading

Description

Temporary PR validating that passing --enable-native-access=io.netty.common when running azure-core-http-netty unit tests will prevent Windows runs from failing with this issue, netty/netty#16071.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Azure.Core azure-core Azure.Identity clientcore common common module used by all azure SDKs (e.g. client, Mgmt) Communication - Common Cosmos Event Hubs Mgmt This issue is related to a management-plane library. OpenAI OpenTelemetry OpenTelemetry instrumentation Voice Live WebPubSub labels Dec 19, 2025
@alzimmermsft alzimmermsft changed the title Az netty update pass native access Enable native access for Netty common to prevent Windows testing error Dec 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-core-http-netty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samvaity samvaity Awaiting requested review from samvaity samvaity will be requested when the pull request is marked ready for review samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay will be requested when the pull request is marked ready for review g2vinay is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

@rujche rujche Awaiting requested review from rujche rujche will be requested when the pull request is marked ready for review rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy will be requested when the pull request is marked ready for review Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna will be requested when the pull request is marked ready for review saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan will be requested when the pull request is marked ready for review moarychan is a code owner

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft will be requested when the pull request is marked ready for review weidongxu-microsoft is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft will be requested when the pull request is marked ready for review haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao will be requested when the pull request is marked ready for review XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 will be requested when the pull request is marked ready for review ArthurMa1978 is a code owner

@bganapa bganapa Awaiting requested review from bganapa bganapa will be requested when the pull request is marked ready for review bganapa is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar will be requested when the pull request is marked ready for review srnagar is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree will be requested when the pull request is marked ready for review joshfree is a code owner

@vicancy vicancy Awaiting requested review from vicancy vicancy will be requested when the pull request is marked ready for review vicancy is a code owner

@chenkennt chenkennt Awaiting requested review from chenkennt chenkennt will be requested when the pull request is marked ready for review chenkennt is a code owner

@zackliu zackliu Awaiting requested review from zackliu zackliu will be requested when the pull request is marked ready for review zackliu is a code owner

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl jpalvarezl will be requested when the pull request is marked ready for review jpalvarezl is a code owner

@axisc axisc Awaiting requested review from axisc axisc will be requested when the pull request is marked ready for review axisc is a code owner

@sjkwak sjkwak Awaiting requested review from sjkwak sjkwak will be requested when the pull request is marked ready for review sjkwak is a code owner

@hmlam hmlam Awaiting requested review from hmlam hmlam will be requested when the pull request is marked ready for review hmlam is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli will be requested when the pull request is marked ready for review kirankumarkolli is a code owner

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB will be requested when the pull request is marked ready for review AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms will be requested when the pull request is marked ready for review maximrytych-ms is a code owner

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft will be requested when the pull request is marked ready for review mjafferi-msft is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 will be requested when the pull request is marked ready for review vcolin7 is a code owner

@rhurey rhurey Awaiting requested review from rhurey rhurey will be requested when the pull request is marked ready for review rhurey is a code owner

@xitzhang xitzhang Awaiting requested review from xitzhang xitzhang will be requested when the pull request is marked ready for review xitzhang is a code owner

@amber-yujueWang amber-yujueWang Awaiting requested review from amber-yujueWang amber-yujueWang will be requested when the pull request is marked ready for review amber-yujueWang is a code owner

@trask trask Awaiting requested review from trask trask will be requested when the pull request is marked ready for review trask is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy will be requested when the pull request is marked ready for review anuchandy is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Azure.Core azure-core Azure.Identity clientcore common common module used by all azure SDKs (e.g. client, Mgmt) Communication - Common Cosmos Event Hubs Mgmt This issue is related to a management-plane library. OpenAI OpenTelemetry OpenTelemetry instrumentation Voice Live WebPubSub

Projects

Azure Identity SDK Improvements
Status: Untriaged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alzimmermsft