Skip to content

fix changelog tool #46793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ChenxiJiang333 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Draft

fix changelog tool #46793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b5575c
fix-changelog-tool
ChenxiJiang333 May 8, 2026
80d6a15
Merge branch 'main' into fix-changelog-tool
ChenxiJiang333 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/breaking_changes_checker/breaking_changes_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,8 @@ def check_class_instance_attribute_removed_or_renamed(self, components: Dict) ->
for property in deleted_props:
bc = None
if self._class_name.endswith("Client"):
property_type = self.stable[self._module_name]["class_nodes"][self._class_name]["properties"][property]["attr_type"]
property_data = self.stable[self._module_name]["class_nodes"][self._class_name]["properties"][property]
property_type = property_data["attr_type"] if isinstance(property_data, dict) else property_data
# property_type is not always a string, such as client_side_validation which is a bool, so we need to check for strings
if property_type is not None and isinstance(property_type, str) and property_type.lower().endswith("operations"):
bc = (
Expand Down
3 changes: 2 additions & 1 deletion scripts/breaking_changes_checker/changelog_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ def run_non_breaking_class_level_diff_checks(self, module: Dict) -> None:
self.module_name, class_name, property_name
)
if self.class_name.endswith("Client"):
if property_components["attr_type"] is not None and property_components["attr_type"].lower().endswith("operations"):
attr_type = property_components["attr_type"] if isinstance(property_components, dict) else property_components
if attr_type is not None and attr_type.lower().endswith("operations"):
fa = (
self.ADDED_OPERATION_GROUP_MSG,
ChangeType.ADDED_OPERATION_GROUP,
Expand Down
Loading