[Storage] [Datalake] Fixed all next-pylint errors for azure-storage-file-datalake#46809
Open
weirongw23-msft wants to merge 4 commits intoAzure:mainfrom
Open
[Storage] [Datalake] Fixed all next-pylint errors for azure-storage-file-datalake#46809weirongw23-msft wants to merge 4 commits intoAzure:mainfrom
next-pylint errors for azure-storage-file-datalake#46809weirongw23-msft wants to merge 4 commits intoAzure:mainfrom
Conversation
weirongw23-msft
requested review from
jalauzon-msft and
vincenttran-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets azure-storage-file-datalake by cleaning up next-pylint findings primarily in tests and samples via import ordering, formatting, and a handful of assertion/exception-handling tweaks.
Changes:
- Reformats and reorganizes imports across tests/samples, and rewrites long literals/calls for lint compliance.
- Adjusts several test assertions and error-handling branches (e.g.,
ValueErrorexpectations, fixedreplace()usage). - Updates perfstress and sample code for lint-friendly structure and exception handling.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-datalake/tests/test_quick_query.py | Reformats test data and assertions; adjusts query tests and error handling. |
| sdk/storage/azure-storage-file-datalake/tests/test_large_file.py | Import/formatting cleanup and decorator formatting. |
| sdk/storage/azure-storage-file-datalake/tests/test_large_file_async.py | Import/formatting cleanup and decorator formatting for async tests. |
| sdk/storage/azure-storage-file-datalake/tests/test_helpers.py | Import ordering and pylint suppression for transport imports. |
| sdk/storage/azure-storage-file-datalake/tests/test_helpers_async.py | Import ordering and pylint suppression for async transport imports. |
| sdk/storage/azure-storage-file-datalake/tests/test_file.py | Import ordering, formatting of long calls/literals, and helper tweaks. |
| sdk/storage/azure-storage-file-datalake/tests/test_file_system.py | Import ordering and more specific exception handling in helpers. |
| sdk/storage/azure-storage-file-datalake/tests/test_file_system_async.py | Import ordering, helper exception handling, and small assertion change. |
| sdk/storage/azure-storage-file-datalake/tests/test_file_async.py | Import ordering and formatting of long calls/literals for async tests. |
| sdk/storage/azure-storage-file-datalake/tests/test_directory.py | Import ordering, formatting, and some assertion fixes. |
| sdk/storage/azure-storage-file-datalake/tests/test_directory_async.py | Import ordering and formatting for async directory tests. |
| sdk/storage/azure-storage-file-datalake/tests/test_datalake_service_client.py | Import ordering and minor loop/style cleanups. |
| sdk/storage/azure-storage-file-datalake/tests/test_datalake_service_client_async.py | Import ordering and minor loop/style cleanups for async. |
| sdk/storage/azure-storage-file-datalake/tests/test_cpk.py | Import ordering cleanup. |
| sdk/storage/azure-storage-file-datalake/tests/test_cpk_async.py | Import ordering cleanup. |
| sdk/storage/azure-storage-file-datalake/tests/settings/testcase.py | Updates pylint disables and environment-variable formatting. |
| sdk/storage/azure-storage-file-datalake/tests/perfstress_tests/upload.py | Consolidates perfstress imports. |
| sdk/storage/azure-storage-file-datalake/tests/perfstress_tests/_test_base.py | Removes unused imports and reformats CLI argument definitions. |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_service_async.py | Moves imports to module scope and reformats sample blocks. |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_query.py | Adds explicit exception import and refactors formatting/exception handling. |
| self.dsc.create_file_system(self.filesystem_name) | ||
| except: | ||
| pass | ||
|
|
| file_system.create_file_system(timeout=5) | ||
| except ResourceExistsError: | ||
| pass | ||
|
|
|
|
||
| except ResourceExistsError: | ||
| pass | ||
|
|
| file_system.create_file_system(timeout=5) | ||
| except ResourceExistsError: | ||
| pass | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.