[eno] Use foreground deletion for resources #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhan
reviewed
Feb 5, 2026
| deletionPropagation := metav1.DeletePropagationForeground | ||
| opts = append(opts, client.PropagationPolicy(deletionPropagation)) | ||
| logger.Info("deleting resource with foreground deletion") | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add deletion options when calling err := c.upstreamClient.Delete(ctx, current, opts...)
Local reproduction for fix:
ruinanliu@ruinanliu-work:
/playground/deletion_group$ k get crd -A --kubeconfig target-cls/playground/deletion_group$ k get schedulerconfiguration -A --kubeconfig target-clsNAME CREATED AT
nodenetworkconfigs.acn.azure.com 2026-02-05T17:52:04Z
overlayextensionconfigs.acn.azure.com 2026-02-05T17:52:04Z
volumesnapshotclasses.snapshot.storage.k8s.io 2026-02-05T17:52:16Z
volumesnapshotcontents.snapshot.storage.k8s.io 2026-02-05T17:52:16Z
volumesnapshots.snapshot.storage.k8s.io 2026-02-05T17:52:16Z
ruinanliu@ruinanliu-work:
Error from server (NotFound): Unable to list "aks.azure.com/v1alpha1, Resource=schedulerconfigurations": the server could not find the requested resource (get schedulerconfigurations.aks.azure.com)
ruinanliu@ruinanliu-work:
/playground/deletion_group$ k get schedulerconfiguration -A --kubeconfig target-cls ^C/playground/deletion_group$ aksdev cluster get C --azureconfig azureconfig.yaml | grep provisioningruinanliu@ruinanliu-work:
"provisioningState": "Succeeded",
"provisioningState": "Succeeded",