Skip to content

Fix other reason comments. #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkaradzic-microsoft merged 1 commit into from
May 9, 2026
Merged

Fix other reason comments. #1692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions Apps/Playground/Scripts/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@
"playgroundId": "#1VGT5D#2",
"renderCount": 50,
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
"referenceImage": "particle-helper.png"
},
{
Expand Down Expand Up @@ -1660,7 +1660,7 @@
"renderCount": 100,
"referenceImage": "particles.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "PBRMetallicRoughnessMaterial",
Expand Down Expand Up @@ -2441,7 +2441,7 @@
"playgroundId": "#544N0Q#67",
"renderCount": 120,
"excludeFromAutomaticTesting": true,
"reason": "After #1569 stride fix, hits bgfx 'Invalid texture attachment' frame buffer validation (exit 1); needs separate investigation.",
"reason": "After #1691 stride fix, hits bgfx 'Invalid texture attachment' frame buffer validation (exit 1); needs separate investigation.",
"referenceImage": "fluidParticleSystem.png"
},
{
Expand Down Expand Up @@ -2863,7 +2863,7 @@
"playgroundId": "#2441BU#1",
"renderCount": 20,
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
"referenceImage": "halo-particle-system.png"
},
{
Expand All @@ -2879,7 +2879,7 @@
"playgroundId": "#DMLLV2",
"renderCount": 5,
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
"referenceImage": "particle-system-with-custom-nme-shader.png"
},
{
Expand Down Expand Up @@ -4292,7 +4292,7 @@
"renderCount": 120,
"referenceImage": "NME-Particles-with-PositionW.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Basic Properties - Size",
Expand All @@ -4312,7 +4312,7 @@
"renderCount": 120,
"referenceImage": "particles-basic-color.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Basic Properties - Speed",
Expand Down Expand Up @@ -4344,7 +4344,7 @@
"renderCount": 120,
"referenceImage": "particles-basic-direction.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Basic Properties - Direction - Gravity",
Expand All @@ -4364,7 +4364,7 @@
"renderCount": 120,
"referenceImage": "particles-basic-emit-rate-fast.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Basic Properties - Emission Limits",
Expand All @@ -4390,7 +4390,7 @@
"renderCount": 120,
"referenceImage": "particles-basic-change-size.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Change - Size 2",
Expand All @@ -4404,15 +4404,15 @@
"renderCount": 120,
"referenceImage": "particles-basic-change-color.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Change - Color 2",
"playgroundId": "#0K3AQ2#3851",
"renderCount": 120,
"referenceImage": "particles-basic-change-color-2.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Change - Speed",
Expand Down Expand Up @@ -4474,7 +4474,7 @@
"renderCount": 120,
"referenceImage": "particles-basic-change-lifetime.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Change - Lifetime 2",
Expand All @@ -4494,23 +4494,23 @@
"renderCount": 120,
"referenceImage": "particles-emitters-point.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Emitters - Box",
"playgroundId": "#WLX2I2#8",
"renderCount": 120,
"referenceImage": "particles-emitters-box.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Emitters - Sphere",
"playgroundId": "#WLX2I2#9",
"renderCount": 120,
"referenceImage": "particles-emitters-sphere.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Emitters - Directed Sphere",
Expand All @@ -4530,7 +4530,7 @@
"renderCount": 120,
"referenceImage": "particles-emitters-cylinder.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Emitters - Directed Cylinder",
Expand All @@ -4552,7 +4552,7 @@
"renderCount": 120,
"referenceImage": "particles-emitters-directed-cone.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Emitters - Mesh",
Expand Down Expand Up @@ -4610,7 +4610,7 @@
"renderCount": 120,
"referenceImage": "particles-billboard-false.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Multiply Blend",
Expand Down Expand Up @@ -4640,7 +4640,7 @@
"renderCount": 120,
"referenceImage": "particles-helper-sun.png",
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
},
{
"title": "Particles - Helper - Smoke",
Expand All @@ -4663,7 +4663,7 @@
"playgroundId": "#DEZ79M#73",
"renderCount": 240,
"excludeFromAutomaticTesting": true,
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
"referenceImage": "particles-attractors.png"
},
{
Expand Down
Loading