Re-enable 3 stale-excluded Playground tests (345, 346, 533).#1693
Merged
bkaradzic-microsoft merged 1 commit intoMay 12, 2026
Merged
Conversation
bkaradzic-microsoft
force-pushed
the
reenable-stale-exclusions
branch
from
f640653 to
d5c76da
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Re-enables three previously excluded Playground automatic tests by removing stale excludeFromAutomaticTesting entries whose recorded failure reasons no longer reproduce.
Changes:
- Removed
excludeFromAutomaticTesting+reasonfrom tests 345 and 346 (unicode GUI). - Removed
excludeFromAutomaticTesting+reasonfrom test 533 (OpenPBR analytic lights anisotropy).
Re-enables three tests in Apps/Playground/Scripts/config.json whose `excludeFromAutomaticTesting` reasons no longer match observed behavior: - idx 345 - Load GUI snippet with unicode (was: "Test crashes or hangs on Babylon Native"). Renders and validates at ~2k pixel diff sub-threshold in repeated isolation runs. - idx 346 - Parse GUI json with unicode (was: "Test crashes or hangs on Babylon Native"). Same behavior as 345. - idx 533 - OpenPBR Analytic Lights Anisotropy (was: "Test fails locally on Win32 D3D11 sweep; disabled until BabylonNative fixes are made."). Renders and validates at ~1.3k pixel diff sub-threshold. Also pins the unicode tests' playground IDs to `#YS93KY#0` / `#ERVGT5#0` so the test inputs cannot silently drift if a future revision is published, matching the pinned style of nearby entries (e.g. test 533's `#GRQHVV#61`). Today both snippets only have version 0, so this is a no-op for current behavior; it is a guard against future drift. Verified on Win32 V8 D3D11 Debug: each test exits 0 with `[Log] validated` both in isolation (5 runs each) and in a 3-test in-process batch. CI will exercise them in the full sweep on this PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
reenable-stale-exclusions
branch
from
d5c76da to
0719107
Compare
CedricGuillemet
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables three tests in
Apps/Playground/Scripts/config.jsonwhoseexcludeFromAutomaticTestingreasons no longer match observed behavior.Tests re-enabled
Verification
On Win32 V8 D3D11 Debug build, with the modified config.json:
[Log] validatedwith stable pixel-diff counts.ran=3 passed=3 failed=0.None of the listed failure modes (crash, hang, sweep-only fail) reproduce. CI on this PR will exercise them in the full automatic sweep, which is the authoritative validation.
Notes
errorRatioslightly on that entry or pin its playground snippet version (currently unpinned).