Add CustomMaterial and PBRCustomMaterial docs#1574
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
snapshot for this PR available at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1574/merge |
There was a problem hiding this comment.
Pull request overview
Adds documentation for Babylon.js CustomMaterial and PBRCustomMaterial within the Materials Library, and wires the new page into the Materials Library index and site navigation.
Changes:
- Added a new Materials Library page covering setup, shader hook points, and uniform usage for
CustomMaterialandPBRCustomMaterial, including two Playground examples. - Updated the Materials Library index page to include a link to the new Custom Materials documentation.
- Updated navigation structure to include the new page under the Materials Library section.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/toolsAndResources/assetLibraries/materialsLibrary/customMat.md | New docs page describing CustomMaterial/PBRCustomMaterial usage, hook points, uniforms, and Playground examples. |
| content/toolsAndResources/assetLibraries/materialsLibrary.md | Adds a list of Materials Library pages, including the new Custom Materials link. |
| configuration/structure.json | Adds customMat entry so the new page appears in the navigation tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @grantf04 , thank you so much for the PR. I have no problem with the content, I just want to say that the bounties were external to the Babylon team, so i can't guaranty anything in that regard. I also noticed that the bountry repository was archived. I will ask someone from the team to fully review thins, but it does LGTM! |
Summary
CustomMaterialandPBRCustomMaterialBounty reference: BitReelCo/BJS-PR-Bounty-Pool#5
Verification
#QF2QWZ#0and#W0OF0A#0node -e "JSON.parse(require('fs').readFileSync('configuration/structure.json','utf8'))"content/toolsAndResources/assetLibraries/materialsLibrary/customMat.mdthrough the repo MDX pipelinenpm run buildNotes
npm testcurrently fails on existing snapshot drift in the baseline suite: KaTeX math output andcontent/whats-new.mdsnapshot content. Those failures are unrelated to this docs page.