removes most europe spam#14
Conversation
|
i added another commit in my repo, now it blocks around 7400 spam servers for multiples countries, i also noticed they seem to all use the same range of ip (for example, 1.1.1.1, 1.1.1.2, 1.1.1.3, etc) so it might be a good idea to do a python or someting else script to analyse the ip ranges and find more servers |
|
it now removes a few hundred more spam server |
|
also it looks like the indentation is inconsistent on github but it looks good on my pc |
|
i just realised the readme is included in the pull request, idk how to remove it |
There was a problem hiding this comment.
Not committing with the readme edits. Remove it from PR to be able to merge.
Did you test with removing the ":0" fake port off of all the IP addresses? Having :0 on the end is how these can be put in via the GUI.
Steps for editing online:
Go to the Pull Request.
Click Files changed.
Locate the file, click the three dots next to it, select Delete file (if available).
Commit the change. GitHub will push this to the PR branch and update the PR.
i'm not exactly sure what you mean by that, removing :0 still works for importing, as for adding, i did everything by manually copying to a notepad, was there another way? |
Your update has removed every instance of :0 Old versions required a port. Putting :0 as the port was used to indicate the whole port range. I tested and this appears to have changed. Port is no longer required at all. Readme would still need to be removed from your end to merge |
2 participants
it removes around 2000 for me