delete cloud sync recordings on acc delete#4211
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the functionality to delete a user's private cloud sync recordings from Google Cloud Storage when their account is deleted. This is achieved by adding a new function delete_all_user_private_cloud_sync_data and calling it within the delete_user_data flow.
The review comment suggesting the use of a batch operation for deleting files from GCS is valid and aligns with best practices for efficiency, especially for users with a large amount of data. This comment has been kept as is.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@mdmohsin7 I pulled this PR off the runway, but it’s missing test/demo evidence. Please add test results or a quick screenshot/video in the PR description or a comment so we can confirm expected behavior before review. by AI for @beastoin |
|
Hey @mdmohsin7! This draft PR has been open 28 days with no description or test evidence (a previous review also flagged this). When you're ready to pick it back up, please add a description and test results, then reopen. Happy to review! |
|
Hey @mdmohsin7 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
2 participants
No description provided.