Skip to content

X-Forwarded-For #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BayerC wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

X-Forwarded-For #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/open_cups/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,10 @@ def handle_question_submit() -> None:


def run() -> None:
headers = st.context.headers
ip_address = headers.get("X-Forwarded-For", "Unknown")
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider parsing X-Forwarded-For correctly when it contains a list of IPs.

Many proxies send X-Forwarded-For as client-ip, proxy1, proxy2, .... Using it directly may log the whole chain instead of the client IP. If you want the originating client IP, split on "," and use the first trimmed entry.


st.write(f"Connecting from: {ip_address}")
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 question (security): Double-check whether exposing the client IP in the UI aligns with privacy/user expectations.

Depending on your context, this could be treated as sensitive information. If it’s mainly for diagnostics, consider hiding it behind a debug flag or limiting visibility to admin/privileged users.

st_autorefresh(interval=AUTOREFRESH_INTERVAL_MS, key="data_refresh")

state_provider = StateProvider()
Expand Down
Loading