Draft
Conversation
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
orbeckst
reviewed
Nov 14, 2025
Comment on lines
+200
to
+201
| if self.sinfo.time: | ||
| buf_len += IMDHEADERSIZE + IMDTIMEPACKETLENGTH |
Member
There was a problem hiding this comment.
Suggested change
| if self.sinfo.time: | |
| buf_len += IMDHEADERSIZE + IMDTIMEPACKETLENGTH | |
| buf_len += int(self.sinfo.time) * (IMDHEADERSIZE + IMDTIMEPACKETLENGTH) |
Contributor
There was a problem hiding this comment.
This maybe an issue since sinfo.time >=1 as per the protocol. int(bool(self.sinfo.time)) might be a better option
Suggested change
| if self.sinfo.time: | |
| buf_len += IMDHEADERSIZE + IMDTIMEPACKETLENGTH | |
| buf_len += int(bool(self.sinfo.time)) * (IMDHEADERSIZE + IMDTIMEPACKETLENGTH) |
orbeckst
reviewed
Nov 14, 2025
Comment on lines
+113
to
+116
| if version == 2: | ||
| self._send_handshakeV2() | ||
| elif version == 3: | ||
| self._send_handshakeV3() |
Member
There was a problem hiding this comment.
I know that you're checking version above. It still makes me squirm to have no else so I'd add assert 2 <= version <= 3, just in case the IMDVERSIONS get updated but nothing is done here.
Contributor
|
@ljwoods2 - Is this built to handle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
Changes made in this Pull Request:
PR Checklist