Require C++17 to match ament_index_cpp 1.8.3+#1123
Open
marcoag wants to merge 1 commit intoBehaviorTree:v3.8from
Open
Require C++17 to match ament_index_cpp 1.8.3+#1123marcoag wants to merge 1 commit intoBehaviorTree:v3.8from
marcoag wants to merge 1 commit intoBehaviorTree:v3.8from
Conversation
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the current regression in Jazzy by setting
CMAKE_CXX_STANDARD 17to aligningbehaviortree_cpp_v3withament_index_cpp.Why:
behaviortree_cpp_v3is failing to build againstament_index_cpp 1.8.3becauseget_package_share_directory.hppnow unconditionally includes<filesystem>, which requiresC++17. This package was explicitly settingCMAKE_CXX_STANDARD 14, which caused the compilation to fail when including that header.The breakage should not be blamed on the
ament_index_cppsince the package has requiredC++17since version1.7.0(commit ament/ament_index@43e7b00, Aug 2023): and Jazzy was released 2024-05-23.AFAIK there shouldn't be any downstream impact out of this change since
behaviortree_cpp_v3does not export its C++ standard requirement to consumers